Page MenuHomePhabricator

rkotler (reed kotler)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 15 2014, 2:30 PM (279 w, 5 d)

Recent Activity

Mar 9 2015

rkotler committed rL231665: Add logical ops to Mips fast-isel.
Add logical ops to Mips fast-isel
Mar 9 2015, 9:30 AM
rkotler closed D6599: Add logical ops to Mips fast-isel.
Mar 9 2015, 9:30 AM
rkotler updated D6599: Add logical ops to Mips fast-isel.
Mar 9 2015, 9:29 AM

Mar 3 2015

rkotler added inline comments to D6599: Add logical ops to Mips fast-isel.
Mar 3 2015, 11:35 AM

Mar 2 2015

rkotler updated the diff for D6599: Add logical ops to Mips fast-isel.

Make requested changes to the test case.

Mar 2 2015, 12:24 PM
rkotler added a comment to D7397: Have a way to let fast-isel handle normally optimized library functions.

The normal selection mechanism would work fine but current hack in
fast-isel prevents it.

Mar 2 2015, 10:33 AM

Feb 27 2015

rkotler added inline comments to D6726: [mips][FastISel] Implement shift ops for Mips Fast-Isel..
Feb 27 2015, 3:22 PM
rkotler updated the diff for D6726: [mips][FastISel] Implement shift ops for Mips Fast-Isel..

Add test case/

Feb 27 2015, 2:09 PM
rkotler added inline comments to D6599: Add logical ops to Mips fast-isel.
Feb 27 2015, 10:34 AM

Feb 26 2015

rkotler added a comment to D6726: [mips][FastISel] Implement shift ops for Mips Fast-Isel..

The C code for the test case was modified. I will finish it up tomorrow.

Feb 26 2015, 6:57 PM
rkotler added a comment to D6726: [mips][FastISel] Implement shift ops for Mips Fast-Isel..

I am working on the make check test. Attached is the C code that was the original test case.

Feb 26 2015, 6:23 PM
rkotler updated the diff for D6726: [mips][FastISel] Implement shift ops for Mips Fast-Isel..

Freshen up patch to tip of tree.

Feb 26 2015, 3:20 PM

Feb 25 2015

rkotler updated the diff for D6599: Add logical ops to Mips fast-isel.

Make Eric Christophers suggest change to remove the test for isVectorAllowed since this is not currently
an issue for Mips32 fast-isel... we don't support any vector types.

Feb 25 2015, 6:00 PM
rkotler updated the diff for D6599: Add logical ops to Mips fast-isel.

Finish up test case.
Merge to tip of tree and run clang format.
Will go through past comments to make sure all nits have been addressed and then will request final push approval.

Feb 25 2015, 3:46 PM

Feb 23 2015

rkotler committed rL230300: Beginning of alloca implementation for Mips fast-isel.
Beginning of alloca implementation for Mips fast-isel
Feb 23 2015, 6:38 PM
rkotler closed D6426: Beginning of alloca implementation for Mips fast-isel.
Feb 23 2015, 6:38 PM

Feb 19 2015

rkotler updated the diff for D6599: Add logical ops to Mips fast-isel.

FIx nits from previous review and rerun clang-format on the result.
What remains is to rewrite the test case.

Feb 19 2015, 8:31 PM
rkotler updated the diff for D6599: Add logical ops to Mips fast-isel.

This just brings the previous patch up to tip of tree. The test case will be replaced with a more complete test case and other comments from the previous review will be addressed.

Feb 19 2015, 8:13 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

test-suite passes on latest push on O0/O2 and mips32 R1/R2

Feb 19 2015, 6:44 PM
rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.

Am in the processing of verifying this patch with test-suite at O0/O2 for mips 23 r1/r2

Feb 19 2015, 4:31 PM

Feb 18 2015

rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

Had responded but did not hit the "submit" button.

Feb 18 2015, 6:56 PM
rkotler added inline comments to D6426: Beginning of alloca implementation for Mips fast-isel.
Feb 18 2015, 6:56 PM
rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.

Eliminate unused parameter in ComputeAddress per Eric Christophers suggestion.

Feb 18 2015, 6:26 PM
rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.

Incorporate Eric Christopher's changes.

Feb 18 2015, 4:25 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

Sorry. I will make your changes.

Feb 18 2015, 3:54 PM
rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.

Add one more requested change. Will rerun test-suite at O0/O2 and mips32 r1/r2 on this change.

Feb 18 2015, 3:40 PM
rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.

Missed a pair of superfluous semicolons.

Feb 18 2015, 1:46 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

New patch coming... something was wrong with this diff.

Feb 18 2015, 1:35 PM
rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.

Incorporate latest comments.

Feb 18 2015, 1:16 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

Getting rid of TargetSupported is possible but we need to add more build bots locally at Imagination to test for non pic and it's currently not in scope for my work now but management decided earlier that you can increase the scope but I just wanted to make it clear that this is an increase of scope of the project to non pic.

Feb 18 2015, 11:07 AM

Feb 17 2015

rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.

Test suite passes on O0/O2 for Mips 32 r1/r2.

Feb 17 2015, 7:08 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

Will upload changed source reflecting the latest comments I posted.

Feb 17 2015, 6:41 PM

Feb 13 2015

rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.

This hopefully freshens up the patch to current tip of tree without undoing any of Chandler or Eric Cs changes.
I am rerunning test-suite and then will make Daniels requested changes and any of Erics which still remain
after this rebasing.

Feb 13 2015, 9:24 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

I'm going to back to redo this patch sequence.

Feb 13 2015, 4:24 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

I see that you and Chandler made some changes in this area.

Feb 13 2015, 4:20 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

Unfortunately, my patches that I'm trying to finally commit now are
very old and they have been blocked
in the patch review queue for months now.

Feb 13 2015, 4:09 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

Subtarget is initialized first and then TargetSupported.

Feb 13 2015, 4:00 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

Hi Eric,

Feb 13 2015, 3:47 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

Not sure I understand some of these comments.

Feb 13 2015, 3:32 PM
rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.

Run clang format on patch.

Feb 13 2015, 3:14 PM
rkotler updated subscribers of D6426: Beginning of alloca implementation for Mips fast-isel.
Feb 13 2015, 2:41 PM
rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

Patch has been updated to be consistent with current state of LLVM (this patch is old). This version should have no functional changes and has been checked against test-suite at O0/O2 and for mips32 R1/R2.

Feb 13 2015, 1:28 PM
rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.
Feb 13 2015, 1:26 PM

Feb 12 2015

rkotler accepted rL228958: Add bulk of returning of values to Mips fast-isel.
Feb 12 2015, 1:18 PM
rkotler committed rL228958: Add bulk of returning of values to Mips fast-isel.
Add bulk of returning of values to Mips fast-isel
Feb 12 2015, 1:07 PM
rkotler closed D5920: Add bulk of returning of values to Mips fast-isel.
Feb 12 2015, 1:07 PM
rkotler updated D5920: Add bulk of returning of values to Mips fast-isel.
Feb 12 2015, 1:06 PM

Feb 10 2015

rkotler updated the diff for D5920: Add bulk of returning of values to Mips fast-isel.

Fixed issues from last review.

Feb 10 2015, 2:48 PM

Feb 9 2015

rkotler added inline comments to D5920: Add bulk of returning of values to Mips fast-isel.
Feb 9 2015, 8:25 PM
rkotler added a comment to D7397: Have a way to let fast-isel handle normally optimized library functions.

But I would still like to apply my patch first while we investigate that
there is no unwanted ramifications
that would affect other ports.

Feb 9 2015, 3:28 PM
rkotler added a comment to D7397: Have a way to let fast-isel handle normally optimized library functions.

It seems from this history of this problem that we could just delete the
code for all targets that my patch works around.

Feb 9 2015, 3:26 PM

Feb 4 2015

rkotler added a comment to D7397: Have a way to let fast-isel handle normally optimized library functions.

In a later patch,

Feb 4 2015, 6:58 PM
rkotler added a comment to D7397: Have a way to let fast-isel handle normally optimized library functions.

The problem with this approach is that the fast-isel code for a given target can always force things to fall back to selection dag but this patch forces it to do that in all cases.

Feb 4 2015, 6:38 PM
rkotler added a comment to D7397: Have a way to let fast-isel handle normally optimized library functions.

http://llvm.org/klaus/llvm/commit/d49edb7ab098fa0c82f59efbcf1b4eb2958f8dc3/

Feb 4 2015, 6:36 PM
rkotler added a comment to D7397: Have a way to let fast-isel handle normally optimized library functions.

This original code was added by Bob Wilson.

Feb 4 2015, 6:34 PM
rkotler added a comment to D7397: Have a way to let fast-isel handle normally optimized library functions.

Correction: the override code placed in the derived fast-isel constructor is:

Feb 4 2015, 1:48 PM
rkotler added a comment to D7397: Have a way to let fast-isel handle normally optimized library functions.

I don't know what the current logic is behind having fast-isel not treat these C library as ordinary functions so I'm not prepared to force what I want on other ports. It clearly makes no sense in the MIps port because the result is that fast-isel will quit there and for Mips we are trying to minimize this behavior so that the code generation runs faster.

Feb 4 2015, 1:42 PM

Feb 3 2015

rkotler updated the test plan for D7397: Have a way to let fast-isel handle normally optimized library functions.
Feb 3 2015, 8:18 PM
rkotler abandoned D7396: Have a way to let fast-isel handle normally optimized library functions.

Superseded by http://reviews.llvm.org/D7397

Feb 3 2015, 6:31 PM
rkotler retitled D7397: Have a way to let fast-isel handle normally optimized library functions from to Have a way to let fast-isel handle normally optimized library functions.
Feb 3 2015, 6:02 PM
rkotler added a comment to D7396: Have a way to let fast-isel handle normally optimized library functions.

adding llvm commits to this

Feb 3 2015, 5:47 PM
rkotler updated subscribers of D7396: Have a way to let fast-isel handle normally optimized library functions.
Feb 3 2015, 5:47 PM
rkotler retitled D7396: Have a way to let fast-isel handle normally optimized library functions from to Have a way to let fast-isel handle normally optimized library functions.
Feb 3 2015, 5:46 PM

Jan 27 2015

rkotler added a comment to D7219: [mips][FastISel] Implement bswap..

Submit to commits list for comments too.

Jan 27 2015, 6:33 PM
rkotler updated subscribers of D7219: [mips][FastISel] Implement bswap..
Jan 27 2015, 6:32 PM
rkotler retitled D7219: [mips][FastISel] Implement bswap. from to Implement bswap for mips fast-isel.
Jan 27 2015, 6:31 PM

Jan 23 2015

rkotler retitled D7158: [mips][FastISel] Implement intrinsics memset, memcopy & memmove. from to Implement intrinsics memset, memcopy and memmove in Mips fast-isel.
Jan 23 2015, 8:04 PM

Jan 16 2015

rkotler retitled D7028: [mips][FastISel] Implement div instruction. from to add div to mips fast-isel.
Jan 16 2015, 7:32 PM
rkotler retitled D7027: [mips][FastISel] Implement srem and urem. from to Implement srem, urem in Mips fast-isel.
Jan 16 2015, 5:53 PM

Jan 14 2015

rkotler updated the diff for D6774: [mips][FastISel] Implement the select statement for MIPS FastISel..

A regression was fixed here because it shows up in test-suite only after this patch. It's a generic problem caused by a shortcoming in tabelgen whereby you can't mark a side effect of an instruction as it making a register Dead and instead out tablegen marked the mul instruction wirh defs for LO0 and HI0 which causes a problem for the register allocator when trying to allocate register AC0 since LO0 and HI0 are dependent registers.

Jan 14 2015, 5:43 PM

Jan 13 2015

rkotler added a comment to D5920: Add bulk of returning of values to Mips fast-isel.

I think that the 8/16 return values are dealt with in a later patch.

Jan 13 2015, 2:03 PM

Dec 24 2014

rkotler abandoned D4078: Implement Mips fast-isel signed and unsigned integer compare.

Superseded by D5566

Dec 24 2014, 2:04 PM
rkotler abandoned D4241: Implement conditional branch in Mips fast-isel.

superseded by D5583

Dec 24 2014, 2:02 PM
rkotler updated the diff for D5920: Add bulk of returning of values to Mips fast-isel.
Dec 24 2014, 1:11 PM
rkotler abandoned D4137: Implement Mips fast isel for floating point compare..

Resubmitted as D5567

Dec 24 2014, 10:34 AM

Dec 23 2014

rkotler added a comment to D6774: [mips][FastISel] Implement the select statement for MIPS FastISel..

Simple executable test case.

Dec 23 2014, 6:22 PM
rkotler retitled D6774: [mips][FastISel] Implement the select statement for MIPS FastISel. from to Implement mips fast-isel select statement.
Dec 23 2014, 6:20 PM
rkotler retitled D6770: [mips][FastISel] Handle calls with non legal types i8 and i16. from to Mips fast-isel - handle calls with non legal types i8, i16.
Dec 23 2014, 8:00 AM

Dec 22 2014

rkotler retitled D6767: [mips][FastISel] Allow computation of addresses from constant expressions. from to Allow for constant data to be referenced in Mips-fast-isel.
Dec 22 2014, 5:36 PM
rkotler retitled D6765: [mips][FastISel] Handle functions which return i1, i8 or i16. from to Mips fast-isel - handle functions which return i8 or i6 ..
Dec 22 2014, 4:09 PM

Dec 19 2014

rkotler retitled D6742: Implement FastMaterializeAlloca in Mips fast-isel from to Implement FastMaterializeAlloca in Mips fast-isel.
Dec 19 2014, 2:05 PM

Dec 18 2014

rkotler retitled D6726: [mips][FastISel] Implement shift ops for Mips Fast-Isel. from to Implement shift ops for Mips fast-isel.
Dec 18 2014, 11:30 AM

Dec 10 2014

rkotler updated subscribers of D6599: Add logical ops to Mips fast-isel.
Dec 10 2014, 5:35 PM
rkotler retitled D6599: Add logical ops to Mips fast-isel from to Add logical ops to Mips fast-isel.
Dec 10 2014, 5:29 PM

Dec 8 2014

rkotler added a comment to D6426: Beginning of alloca implementation for Mips fast-isel.

load1.ll from initial patch is still part of this.

Dec 8 2014, 3:32 PM
rkotler updated the diff for D6426: Beginning of alloca implementation for Mips fast-isel.

Fix a bug for this push for when offsets do not fit in the 16 bit signed offset.
I would have put this in a separate patch but the patch needs some of the new features in this
patch; otherwise it would have to be rewritten for this patch.

Dec 8 2014, 2:59 PM

Nov 26 2014

rkotler retitled D6426: Beginning of alloca implementation for Mips fast-isel from to Beginning of alloca implementation for Mips fast-isel.
Nov 26 2014, 2:43 PM

Nov 14 2014

rkotler updated the diff for D5920: Add bulk of returning of values to Mips fast-isel.

Update returning of values patch to tip of tree and add test case.
This patch is almost identical to the AArch64 implementation. I am continuing to review this patch myself but hope to push it soon after review.

Nov 14 2014, 4:21 PM

Nov 13 2014

rkotler closed D5714: First stage of call lowering for Mips fast-isel.
Nov 13 2014, 3:37 PM
rkotler updated D5714: First stage of call lowering for Mips fast-isel.
Nov 13 2014, 3:36 PM
rkotler updated the diff for D5714: First stage of call lowering for Mips fast-isel.

Oops.. made a mistake on last patch and included some non Mips fast-isel code that had already been committed.

Nov 13 2014, 3:10 PM
rkotler updated the diff for D5714: First stage of call lowering for Mips fast-isel.

Fix one cosmetic nit

Nov 13 2014, 2:59 PM

Nov 12 2014

rkotler abandoned D4024: Do floating point (float, double) to signed int conversions..
Nov 12 2014, 4:23 PM
rkotler abandoned D4011: Implement double -> float truncation.
Nov 12 2014, 4:22 PM
rkotler abandoned D4007: Add floating point extension from float to double.
Nov 12 2014, 4:22 PM
rkotler updated the diff for D5714: First stage of call lowering for Mips fast-isel.

Incorporate comments for LGTM from Daniel Sanders

Nov 12 2014, 3:42 PM

Nov 10 2014

rkotler updated the diff for D5714: First stage of call lowering for Mips fast-isel.

Fix some small changes requested by Daniel; handling of AExt as SExt, and call to llvm_unreachable if an attempt is made to use custom args, since we don't use them and hence don't expect that situation to occur.

Nov 10 2014, 3:39 PM
rkotler updated the diff for D5714: First stage of call lowering for Mips fast-isel.

Update patch to work with tip of tree. Majority of changes to MipsISelLowering.<cpp,h> have been replaced by new files MipsCCState.<h,cpp>

Nov 10 2014, 3:11 PM

Oct 22 2014

rkotler added a comment to D5920: Add bulk of returning of values to Mips fast-isel.

Executable test.

Oct 22 2014, 3:31 PM
rkotler updated subscribers of D5920: Add bulk of returning of values to Mips fast-isel.
Oct 22 2014, 3:28 PM