Page MenuHomePhabricator

Remove support for unsupported MSVC versions
ClosedPublic

Authored by jfb on Aug 2 2019, 9:23 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

jfb created this revision.Aug 2 2019, 9:23 AM
jfb marked an inline comment as done.Aug 2 2019, 9:24 AM
jfb added inline comments.
llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp
77 ↗(On Diff #213062)

This seemed buggy, I think the intent was to get msdia140 if it was available.

aaron.ballman accepted this revision.Aug 2 2019, 9:33 AM
aaron.ballman added a subscriber: aaron.ballman.

LGTM!

This revision is now accepted and ready to land.Aug 2 2019, 9:33 AM

I don't think you need that benchmark change, it will just pop right back in the next time it's updated.

jfb updated this revision to Diff 213068.Aug 2 2019, 9:49 AM
  • Undo benchmark change
jfb added a comment.Aug 2 2019, 9:49 AM

I don't think you need that benchmark change, it will just pop right back in the next time it's updated.

True, I undid that change.

In D65662#1612513, @jfb wrote:

I don't think you need that benchmark change, it will just pop right back in the next time it's updated.

True, I undid that change.

No further comments from me, thanks.

rnk accepted this revision.Aug 2 2019, 2:44 PM

lgtm

llvm/lib/Support/Windows/explicit_symbols.inc
94 ↗(On Diff #213068)

I confirmed that these are not inline anymore.

This revision was automatically updated to reflect the committed changes.