Remove support for unsupported MSVC versions

[jfb]

llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp

77 ↗

(On Diff #213062)

This seemed buggy, I think the intent was to get msdia140 if it was available.

[aaron.ballman]

LGTM!

[lebedev.ri]

I don't think you need that benchmark change, it will just pop right back in the next time it's updated.

[jfb]

• Undo benchmark change

[jfb]

In D65662#1612503, @lebedev.ri wrote:

I don't think you need that benchmark change, it will just pop right back in the next time it's updated.

True, I undid that change.

[lebedev.ri]

In D65662#1612513, @jfb wrote:

In D65662#1612503, @lebedev.ri wrote:

I don't think you need that benchmark change, it will just pop right back in the next time it's updated.

True, I undid that change.

No further comments from me, thanks.

[rnk]

lgtm

llvm/lib/Support/Windows/explicit_symbols.inc

94 ↗

(On Diff #213068)

I confirmed that these are not inline anymore.

llvm/trunk/include/llvm/Demangle/DemangleConfig.h

 // include/llvm/Support/Compiler.h so that LLVMDemangle does not need to take
 // a dependency on LLVMSupport.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_DEMANGLE_COMPILER_H
 #define LLVM_DEMANGLE_COMPILER_H
 
-#ifdef _MSC_VER
-// snprintf is implemented in VS 2015
-#if _MSC_VER < 1900
-#define snprintf _snprintf_s
-#endif
-#endif
-
 #ifndef __has_feature
 #define __has_feature(x) 0
 #endif
 
 #ifndef __has_cpp_attribute
 #define __has_cpp_attribute(x) 0
 #endif
 

llvm/trunk/lib/DebugInfo/PDB/DIA/DIASession.cpp

if (SUCCEEDED(CoCreateInstance(CLSID_DiaSource, nullptr, CLSCTX_INPROC_SERVER,
                                  reinterpret_cast<LPVOID *>(&DiaDataSource))))
     return Error::success();
 
 // If the CoCreateInstance call above failed, msdia*.dll is not registered.
 // Try loading the DLL corresponding to the #included DIA SDK.
 #if !defined(_MSC_VER)
   return llvm::make_error<PDBError>(pdb_error_code::dia_failed_loading);
 #else
-  const wchar_t *msdia_dll = nullptr;
-#if _MSC_VER >= 1900 && _MSC_VER < 2000
-  msdia_dll = L"msdia140.dll"; // VS2015
-#elif _MSC_VER >= 1800
-  msdia_dll = L"msdia120.dll"; // VS2013
-#else
-#error "Unknown Visual Studio version."
+  const wchar_t *msdia_dll = L"msdia140.dll";
 #endif
 
   HRESULT HR;
   if (FAILED(HR = NoRegCoCreate(msdia_dll, CLSID_DiaSource, IID_IDiaDataSource,
                                 reinterpret_cast<LPVOID *>(&DiaDataSource))))
     return ErrorFromHResult(HR, "Calling NoRegCoCreate");
   return Error::success();
 #endif

llvm/trunk/lib/Support/Windows/explicit_symbols.inc

#define INLINE_DEF_FLOAT_SYMBOL(SYM, ARGC) INLINE_DEF_SYMBOL##ARGC(float, SYM)
   INLINE_DEF_FLOAT_SYMBOL(logf, 1)
   INLINE_DEF_FLOAT_SYMBOL(powf, 2)
   INLINE_DEF_FLOAT_SYMBOL(sinf, 1)
   INLINE_DEF_FLOAT_SYMBOL(sinhf, 1)
   INLINE_DEF_FLOAT_SYMBOL(sqrtf, 1)
   INLINE_DEF_FLOAT_SYMBOL(tanf, 1)
   INLINE_DEF_FLOAT_SYMBOL(tanhf, 1)
 
-  // These were added in VS 2013.
-#if (1800 <= _MSC_VER && _MSC_VER < 1900)
-  INLINE_DEF_FLOAT_SYMBOL(copysignf, 2)
-  INLINE_DEF_FLOAT_SYMBOL(fminf, 2)
-  INLINE_DEF_FLOAT_SYMBOL(fmaxf, 2)
-#endif
 #undef INLINE_DEF_FLOAT_SYMBOL
 #endif
 
 #endif