This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Added a skeleton for a semantic highlighting feature to the vscode extension.
AbandonedPublic

Authored by jvikstrom on Jul 29 2019, 5:28 AM.

Details

Summary

This adds a SemanticHighlighting feature to the vscode extension that does not do anything. It adds the notification handler to the clangd client and registers the feature by type intersection on the vscode lsp client capabilities.
The notification handler does not currently do anything if/when clangd sends a semantic highlighting notification.

Event Timeline

jvikstrom created this revision.Jul 29 2019, 5:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2019, 5:28 AM
jvikstrom updated this revision to Diff 212302.Jul 30 2019, 2:40 AM

Removed the experimental capability and added it to the normal capabilites using type intersection.

jvikstrom edited the summary of this revision. (Show Details)Jul 30 2019, 6:57 AM
nridge added a subscriber: nridge.Jul 30 2019, 8:54 PM

The skeleton looks good, but apparently it does nothing (only enable the feature), do you have a small working prototype?

jvikstrom updated this revision to Diff 212523.Jul 31 2019, 1:15 AM

Added check that clangd server actually supports semantic highlighting.

The skeleton looks good, but apparently it does nothing (only enable the feature), do you have a small working prototype?

I've got a prototype that colors all the highlightings red, but it would make the CL become quite big if I added that as well. This felt like a reasonable place to divide it. Do you want me to add that as well or should I keep it as 2-3 CLs? (i.e. this -> TM scopes -> highlighting rendering)

jvikstrom abandoned this revision.Aug 8 2019, 2:11 AM