Page MenuHomePhabricator

[analyzer] exploded-graph-rewriter: Implement manual graph trimming.

Authored by NoQ on Fri, Jul 26, 12:42 PM.



When -trim-egraph is unavailable (say, when you're debugging a crash on a real-world code that takes too long to reduce), it makes sense to view the untrimmed graph up to the crashing node's predecessor, then dump the ID (or a pointer) of the node in the attached debugger, and then trim the dumped graph in order to keep only paths from the root to the node.

Implement the last part of that plan. Now you can do:

$ --to 0x12229acd0

And it'll chop out the unnecessary chunks of the graph. You can also specify multiple nodes and you can specify nodes by stable IDs rather than by pointers.

Diff Detail


Event Timeline

NoQ created this revision.Fri, Jul 26, 12:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Jul 26, 12:42 PM
Charusso accepted this revision.Fri, Jul 26, 2:02 PM

It is a great idea, thanks!

918 ↗(On Diff #211985)

Extra comma at (eg.,

989 ↗(On Diff #211985)

only display for consistency with the above arguments.

This revision is now accepted and ready to land.Fri, Jul 26, 2:02 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptTue, Aug 13, 4:05 PM