Enable CodeGenOpt::None on non-iOS ARM

[capn]

Summary

FastISel didn't work on MCJIT for non-iOS ARM, back in 2013 (r183966).
This appears to have been fixed since.

[capn]

Ping

[lhames]

LGTM. Do you have commit access? If not just let me know and I can commit on your behalf.

[capn]

No, I don't have commit access. Please land it on my behalf. Thanks!

[capn]

Friendly ping. Thanks for landing this on my behalf.

[lhames]

This landed in d2751f8fdf6c072045bab62f6035511e028f46ee (I failed to format the revision number correctly in the commit message, so it wasn’t automatically picked up here, sorry).

Thanks again for the fix!

llvm/lib/ExecutionEngine/TargetSelect.cpp

TargetMachine *EngineBuilder::selectTarget(const Triple &TargetTriple,
   std::string FeaturesStr;
   if (!MAttrs.empty()) {
     SubtargetFeatures Features;
     for (unsigned i = 0; i != MAttrs.size(); ++i)
       Features.AddFeature(MAttrs[i]);
     FeaturesStr = Features.getString();
   }
 
-  // FIXME: non-iOS ARM FastISel is broken with MCJIT.
-  if (TheTriple.getArch() == Triple::arm &&
-      !TheTriple.isiOS() &&
-      OptLevel == CodeGenOpt::None) {
-    OptLevel = CodeGenOpt::Less;
-  }
-
   // Allocate a target...
   TargetMachine *Target =
       TheTarget->createTargetMachine(TheTriple.getTriple(), MCPU, FeaturesStr,
                                      Options, RelocModel, CMModel, OptLevel,
              /*JIT*/ true);
   Target->Options.EmulatedTLS = EmulatedTLS;
   Target->Options.ExplicitEmulatedTLS = true;
 
   assert(Target && "Could not allocate target machine!");
   return Target;
 }