Removes hard coded valuse for alignment in -create.
Test Plan: check-llvm
Removes hard coded valuse for alignment in -create.
Test Plan: check-llvm
Buildable 35614 | |
Build 35613: arc lint + arc unit |
llvm/lib/Object/MachOUniversal.cpp | ||
---|---|---|
164 ↗ | (On Diff #210371) | Personally, I would have split the changes in this file and in MachOUniversal.h into a separate change. That change is a very simple change that could probably merged immediately. |
llvm/test/tools/llvm-lipo/Inputs/CPU10-slice.yaml | ||
2 | CPU10 is not particularly helpful. Would be nice to use the human readable form (m88k). | |
llvm/test/tools/llvm-lipo/Inputs/CPU14-slice.yaml | ||
2 | Similar for the file name | |
llvm/tools/llvm-lipo/llvm-lipo.cpp | ||
350 | ITYM segment instead of all load commands. The alignment of something like LC_REEXPORT_DYLIB seems irrelevant to this or am I mistaken on that? |
llvm/tools/llvm-lipo/llvm-lipo.cpp | ||
---|---|---|
352 | const MachOObjectFile *ObjectFile -> const MachOObjectFile &O |
llvm/test/tools/llvm-lipo/Inputs/CPU10-slice.yaml | ||
---|---|---|
2 | This file and CPU14 are both intended to go into calculateSegmentAlignment() since they are not any of the valid architectures. I just manually changes the CPU types for testing. What would the best naming convention be for this situation? |
Address review comment + removed public MaxSectionAlignment variable to different diff.
llvm/tools/llvm-lipo/llvm-lipo.cpp | ||
---|---|---|
355 | const bool |