Page MenuHomePhabricator

anushabasana (Anusha Basana)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2019, 12:24 PM (13 w, 2 d)

Recent Activity

Wed, Aug 7

anushabasana committed rGa87f856f2d9d: [llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign… (authored by anushabasana).
[llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign…
Wed, Aug 7, 4:27 PM
anushabasana committed rL368235: [llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign….
[llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign…
Wed, Aug 7, 4:25 PM
anushabasana closed D65676: [llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign flags.
Wed, Aug 7, 4:25 PM · Restricted Project
anushabasana updated the diff for D65676: [llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign flags.

fix typo

Wed, Aug 7, 4:10 PM · Restricted Project

Mon, Aug 5

anushabasana committed rGff2c59b3f5f1: [llvm-lipo] Implement -segalign (authored by anushabasana).
[llvm-lipo] Implement -segalign
Mon, Aug 5, 12:08 PM
anushabasana committed rL367908: [llvm-lipo] Implement -segalign.
[llvm-lipo] Implement -segalign
Mon, Aug 5, 12:08 PM
anushabasana closed D65420: [llvm-lipo] Implement -segalign.
Mon, Aug 5, 12:07 PM · Restricted Project

Fri, Aug 2

anushabasana created D65676: [llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign flags.
Fri, Aug 2, 2:23 PM · Restricted Project

Wed, Jul 31

anushabasana committed rGf7fbd6cb9f70: [build] Add the ability to create a symlink for lipo (authored by anushabasana).
[build] Add the ability to create a symlink for lipo
Wed, Jul 31, 9:47 AM
anushabasana committed rL367444: [build] Add the ability to create a symlink for lipo.
[build] Add the ability to create a symlink for lipo
Wed, Jul 31, 9:47 AM
anushabasana closed D65477: [build] add the ability to create a symlink for lipo.
Wed, Jul 31, 9:47 AM · Restricted Project

Tue, Jul 30

anushabasana updated the summary of D65477: [build] add the ability to create a symlink for lipo.
Tue, Jul 30, 1:53 PM · Restricted Project
anushabasana created D65477: [build] add the ability to create a symlink for lipo.
Tue, Jul 30, 1:53 PM · Restricted Project
anushabasana updated the diff for D65420: [llvm-lipo] Implement -segalign.

Added test without segalign for comparison

Tue, Jul 30, 12:01 PM · Restricted Project

Mon, Jul 29

anushabasana committed rG4ebb6e917f4b: [llvm-lipo] Fix test on Windows (authored by anushabasana).
[llvm-lipo] Fix test on Windows
Mon, Jul 29, 3:29 PM
anushabasana committed rL367266: [llvm-lipo] Fix test on Windows.
[llvm-lipo] Fix test on Windows
Mon, Jul 29, 3:28 PM
anushabasana created D65420: [llvm-lipo] Implement -segalign.
Mon, Jul 29, 2:22 PM · Restricted Project
anushabasana committed rGc94e951180ea: [llvm-lipo] Implement -replace (authored by anushabasana).
[llvm-lipo] Implement -replace
Mon, Jul 29, 11:47 AM
anushabasana committed rL367248: [llvm-lipo] Implement -replace.
[llvm-lipo] Implement -replace
Mon, Jul 29, 11:46 AM
anushabasana closed D65247: [llvm-lipo] Implement -replace.
Mon, Jul 29, 11:46 AM · Restricted Project

Fri, Jul 26

anushabasana added a comment to D65342: add 'a' to chmod in llvm-lipo executability tests.

LG, thank you!

Fri, Jul 26, 1:32 PM · Restricted Project

Jul 24 2019

anushabasana created D65251: [llvm-lipo] Add test for -verify_archs.
Jul 24 2019, 4:05 PM · Restricted Project
anushabasana updated the diff for D64871: [llvm-lipo] Implement alignment function in -create.

const bool

Jul 24 2019, 3:50 PM · Restricted Project
anushabasana updated the diff for D65247: [llvm-lipo] Implement -replace.

rename var

Jul 24 2019, 3:45 PM · Restricted Project
anushabasana created D65247: [llvm-lipo] Implement -replace.
Jul 24 2019, 3:19 PM · Restricted Project

Jul 22 2019

anushabasana updated the diff for D64871: [llvm-lipo] Implement alignment function in -create.

Address review comment + removed public MaxSectionAlignment variable to different diff.

Jul 22 2019, 2:43 PM · Restricted Project
anushabasana created D65117: [llvm-Object] Added public MaxSectionAlignment to MachOUniversal.
Jul 22 2019, 2:39 PM · Restricted Project
anushabasana added inline comments to D64871: [llvm-lipo] Implement alignment function in -create.
Jul 22 2019, 2:31 PM · Restricted Project

Jul 18 2019

anushabasana added a comment to D64873: Remove the static initialize introduced in r365099.

LG, thank you!

Jul 18 2019, 3:06 PM · Restricted Project

Jul 17 2019

anushabasana updated the diff for D64871: [llvm-lipo] Implement alignment function in -create.

Include changes: specing and compile error fix

Jul 17 2019, 11:09 AM · Restricted Project
anushabasana updated subscribers of D64871: [llvm-lipo] Implement alignment function in -create.
Jul 17 2019, 10:57 AM · Restricted Project
anushabasana added reviewers for D64871: [llvm-lipo] Implement alignment function in -create: smeenai, alexshap, compnerd, mtrent.
Jul 17 2019, 10:49 AM · Restricted Project
anushabasana removed reviewers for D64871: [llvm-lipo] Implement alignment function in -create: smeenai, alexshap, compnerd, mtrent.
Jul 17 2019, 10:33 AM · Restricted Project
anushabasana created D64871: [llvm-lipo] Implement alignment function in -create.
Jul 17 2019, 10:21 AM · Restricted Project

Jul 15 2019

anushabasana updated the diff for D64668: [llvm-lipo] Implement -info.

Test file uses CHECK-NEXT instead of CHECK

Jul 15 2019, 3:39 PM · Restricted Project
anushabasana updated the diff for D64668: [llvm-lipo] Implement -info.

Address review comments

Jul 15 2019, 1:29 PM · Restricted Project
anushabasana added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 11:16 AM · Restricted Project
anushabasana updated the diff for D64668: [llvm-lipo] Implement -info.

Removed extra OS

Jul 15 2019, 11:15 AM · Restricted Project
anushabasana added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 10:24 AM · Restricted Project
anushabasana updated the diff for D64668: [llvm-lipo] Implement -info.

Address review comments

Jul 15 2019, 10:22 AM · Restricted Project

Jul 12 2019

anushabasana updated the diff for D64668: [llvm-lipo] Implement -info.

Fix diff

Jul 12 2019, 2:51 PM · Restricted Project
anushabasana created D64668: [llvm-lipo] Implement -info.
Jul 12 2019, 2:46 PM · Restricted Project
anushabasana updated the diff for D64102: [llvm-lipo] Implement -create part 1.

Revert last update, was a mistake

Jul 12 2019, 2:41 PM · Restricted Project
anushabasana updated the diff for D64102: [llvm-lipo] Implement -create part 1.
  • [llvm-lipo] Implement -info
Jul 12 2019, 2:37 PM · Restricted Project

Jul 9 2019

anushabasana added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Jul 9 2019, 6:23 PM · Restricted Project
anushabasana updated the diff for D64102: [llvm-lipo] Implement -create part 1.

Updated alignment hardcoding

Jul 9 2019, 6:20 PM · Restricted Project

Jul 8 2019

anushabasana updated the diff for D64102: [llvm-lipo] Implement -create part 1.

Addressed minor review comments

Jul 8 2019, 9:44 AM · Restricted Project

Jul 3 2019

anushabasana updated the diff for D64102: [llvm-lipo] Implement -create part 1.

Removed fat64 flag and addressed other review comments.

Jul 3 2019, 2:19 PM · Restricted Project

Jul 2 2019

anushabasana added a comment to D64102: [llvm-lipo] Implement -create part 1.

@mtrent We have implemented create with the -fat64 flag to specify a fat64binary, similar to cctools lipo.
Do we still need this flag, or can we always create a fat64 binary?
Another option would be to have some sort of auto detection to create a fat64 binary when the offset of a section exceeds 32 bits.

Jul 2 2019, 2:41 PM · Restricted Project
anushabasana created D64102: [llvm-lipo] Implement -create part 1.
Jul 2 2019, 2:23 PM · Restricted Project

Jun 24 2019

anushabasana updated the diff for D63735: [MachOObjectFile]Added Valid Architecture Function.

Fixed style comments.

Jun 24 2019, 3:32 PM · Restricted Project
anushabasana updated the diff for D63735: [MachOObjectFile]Added Valid Architecture Function.

Addressed review comments.

Jun 24 2019, 2:50 PM · Restricted Project
anushabasana created D63735: [MachOObjectFile]Added Valid Architecture Function.
Jun 24 2019, 12:29 PM · Restricted Project
anushabasana added a comment to D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.

I am getting the compile warnings below when compiling on gcc version 7.3.1.

Jun 24 2019, 11:38 AM · Restricted Project

Jun 21 2019

anushabasana updated the diff for D63341: [llvm-lipo] Implement -thin.

Fixed small review comments

Jun 21 2019, 2:29 PM · Restricted Project

Jun 20 2019

anushabasana added a comment to D63341: [llvm-lipo] Implement -thin.

Would be nice if "llvm-lipo -thin" printed a reasonable error message before dumping usage. Apple lipo will print "missing argument to -thin option"

Another difference is llvm-lipo will not validate the arch until all arguments are received, whereas Apple lipo will validate archs immediately. ("lipo -arch asdf")

Would be nice if "llvm-lipo" printed a list of valid archs when the arch is invalid. Currently it prints "llvm-lipo: error: Invalid architecture: asdf" and it exits. Apple lipo prints "unknown architecture specification flag: asdf in specifying thin operation: -thin asdf. known architecture flags are: ..."

PLEASE FIX: llvm-lipo does not support using "-o" in place of "-output"

Note: "llvm-lipo" does not work properly with certain Mach-O executables, such as those built with the -hideARM64 flag.

Jun 20 2019, 10:00 AM · Restricted Project
anushabasana updated the diff for D63341: [llvm-lipo] Implement -thin.

Supports -o for output flag. Fixed order of error checking.

Jun 20 2019, 9:35 AM · Restricted Project

Jun 18 2019

anushabasana added inline comments to D63341: [llvm-lipo] Implement -thin.
Jun 18 2019, 3:06 PM · Restricted Project

Jun 17 2019

anushabasana added a comment to D63341: [llvm-lipo] Implement -thin.

Regarding the error messages, should should they replicate cctools lipo exactly?
Currently have small differences like "no output file specified" vs "thin expects a single output file".
If so, I can create a separate diff to change all the error messages.

Jun 17 2019, 2:32 PM · Restricted Project
anushabasana updated the diff for D63341: [llvm-lipo] Implement -thin.

Added comments, fixed error messages, and print error for archive files.

Jun 17 2019, 1:56 PM · Restricted Project

Jun 14 2019

anushabasana created D63341: [llvm-lipo] Implement -thin.
Jun 14 2019, 9:47 AM · Restricted Project

Jun 11 2019

anushabasana updated the diff for D63100: [llvm-lipo] Update llvm-lipo docs for -archs flag.

Clarified description.

Jun 11 2019, 9:39 AM · Restricted Project

Jun 10 2019

anushabasana updated the diff for D63100: [llvm-lipo] Update llvm-lipo docs for -archs flag.

Added more detail

Jun 10 2019, 4:03 PM · Restricted Project
anushabasana created D63100: [llvm-lipo] Update llvm-lipo docs for -archs flag.
Jun 10 2019, 3:22 PM · Restricted Project

Jun 7 2019

anushabasana updated the diff for D62753: [llvm-lipo] Implement -archs.

Added Expected<> error check

Jun 7 2019, 1:32 PM · Restricted Project
anushabasana updated the diff for D62753: [llvm-lipo] Implement -archs.

Address review comments

Jun 7 2019, 10:25 AM · Restricted Project

Jun 5 2019

anushabasana added a comment to D62753: [llvm-lipo] Implement -archs.

Ping

Jun 5 2019, 5:18 PM · Restricted Project
anushabasana updated the diff for D62753: [llvm-lipo] Implement -archs.

Small changes from review comments

Jun 5 2019, 5:06 PM · Restricted Project

May 31 2019

anushabasana updated the diff for D62753: [llvm-lipo] Implement -archs.

Address review comments

May 31 2019, 5:24 PM · Restricted Project
anushabasana created D62753: [llvm-lipo] Implement -archs.
May 31 2019, 2:58 PM · Restricted Project

May 22 2019

anushabasana abandoned D62277: [llvm-objdump] Emit error if start address equal to stop address.

Diff already exists: D61969. I was just getting familiar with llvm.

May 22 2019, 5:34 PM · Restricted Project
anushabasana created D62277: [llvm-objdump] Emit error if start address equal to stop address.
May 22 2019, 5:33 PM · Restricted Project