This is an archive of the discontinued LLVM Phabricator instance.

Differential D64499

[PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin
ClosedPublic

Authored by jsji on Jul 10 2019, 7:47 AM.

Details

Reviewers
kbarton
hfinkel
nemanjai
Commits
rG65e34a3143c4: [PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin
rL366255: [PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin
Summary

This is exposed by our internal testing.
The reduced testcase will assert with "Impossible reg-to-reg copy"

We can't use COPY to do 32-bit to 64-bit conversion.

Diff Detail

Event Timeline

jsji created this revision.Jul 10 2019, 7:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 7:47 AM
Herald added subscribers: llvm-commits, MaskRay, hiraditya. · View Herald Transcript
Harbormaster completed remote builds in B34697: Diff 208965.Jul 10 2019, 7:47 AM
jsji added a comment.Jul 16 2019, 10:19 AM

Ping..

hfinkel accepted this revision.Jul 16 2019, 12:57 PM

LGTM

This revision is now accepted and ready to land.Jul 16 2019, 12:57 PM
Closed by commit rL366255: [PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin (authored by jsji). · Explain WhyJul 16 2019, 1:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
PowerPC/
4 lines
test/
CodeGen/
PowerPC/
30 lines

Diff 208965

llvm/lib/Target/PowerPC/PPCInstrHTM.td

Show First 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
def : Pat<(int_ppc_tresume), def : Pat<(int_ppc_tresume),
(TSR 1)>; (TSR 1)>;
def : Pat<(int_ppc_tsuspend), def : Pat<(int_ppc_tsuspend),
(TSR 0)>; (TSR 0)>;
def : Pat<(i64 (int_ppc_ttest)), def : Pat<(i64 (int_ppc_ttest)),
(RLDICL (i64 (COPY (TABORTWCI 0, (LI 0), 0))), 36, 28)>; (RLDICL (i64 (INSERT_SUBREG (i64 (IMPLICIT_DEF)),
(TABORTWCI 0, (LI 0), 0), sub_32)),
36, 28)>;
} // [HasHTM] } // [HasHTM]

llvm/test/CodeGen/PowerPC/htm-ttest.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc -mtriple=powerpc64le-unknown-linux-gnu -verify-machineinstrs \
; RUN: -mcpu=pwr8 -mattr=+htm < %s | FileCheck %s
define dso_local void @main() #0 {
; CHECK-LABEL: main:
; CHECK: # %bb.0:
; CHECK-NEXT: li 3, 0
; CHECK-NEXT: tabortwci. 0, 3, 0
; CHECK-NEXT: mfocrf 3, 128
; CHECK-NEXT: rldicl 3, 3, 36, 28
; CHECK-NEXT: rlwinm. 3, 3, 31, 30, 31
; CHECK-NEXT: beqlr+ 0
; CHECK-NEXT: # %bb.1:
%1 = call i64 @llvm.ppc.ttest() #1
%2 = lshr i64 %1, 1
%3 = and i64 %2, 3
%4 = icmp eq i64 %3, 0
br i1 %4, label %5, label %6
5: ; preds = %0
ret void
6: ; preds = %0
unreachable
}
; Function Attrs: nounwind
declare i64 @llvm.ppc.ttest() #1