This is an archive of the discontinued LLVM Phabricator instance.

[test] [llvm-objcopy] Fix broken test case
ClosedPublic

Authored by abrachet on Jul 7 2019, 5:33 PM.

Details

Summary

The test case added in D62718 did not work unless the user was root because write bits were not set for the output file. This change uses only permissions with user write (0200) to ensure tests pass regardless of the users permissions.

Diff Detail

Event Timeline

abrachet created this revision.Jul 7 2019, 5:33 PM
MaskRay added inline comments.Jul 7 2019, 8:30 PM
llvm/test/tools/llvm-objcopy/ELF/respect-umask.test
34

You can join the two lines:

ls -l %t2 | cut -f 1 -d ' ' | cmp - %t.0600

abrachet updated this revision to Diff 208312.Jul 7 2019, 9:22 PM

Consolidated RUN lines.

abrachet marked an inline comment as done.Jul 7 2019, 9:27 PM
MaskRay accepted this revision.Jul 8 2019, 11:17 PM
This revision is now accepted and ready to land.Jul 8 2019, 11:17 PM
This revision was automatically updated to reflect the committed changes.