Exactly what it says on the tin! The comments in the code detail this a little more too.
NoQ xazax.hun rnkovacs dcoughlin Charusso baloghadamsoftware
- rG967583bc087c: [analyzer] Note last writes to a condition only in a nested stackframe
rC368817: [analyzer] Note last writes to a condition only in a nested stackframe
rL368817: [analyzer] Note last writes to a condition only in a nested stackframe
I have one small question otherwise looks good.
I wonder if "nested" is a good term in the title of this revision. We could also show notes in the caller right? So it might also be an "enclosing" frame. And if so, is it desired? Since the "enclosing" frames should already be visible for the user without the additional notes. But correct me if I'm wrong :)
Yeah, interesting, i guess we should also not track the value further. Otherwise it'd be weird that one piece in the middle is missing but everything else is still there.
That is what D64271 was for, and I think it would be a bad idea. What we should rather do is have a better note message:
Like here. We'd lose this note if we didn't track further. I'm already gathering data tho!