This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Some tweaks on semantic highlighting lookuptable.
ClosedPublic

Authored by hokein on Jul 4 2019, 4:34 AM.

Event Timeline

hokein created this revision.Jul 4 2019, 4:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2019, 4:34 AM
sammccall accepted this revision.Jul 4 2019, 5:08 AM
sammccall added inline comments.
clang-tools-extra/clangd/ClangdLSPServer.cpp
87

while here, can we have "highlight" in the name? like "buildHighlightScopeLookupTable"?

clang-tools-extra/clangd/SemanticHighlighting.cpp
161
clang-tools-extra/clangd/SemanticHighlighting.h
30

the name is a little confusing as it's last-plus-one. NumKinds is a common idiom I think.

This revision is now accepted and ready to land.Jul 4 2019, 5:08 AM
hokein updated this revision to Diff 208020.Jul 4 2019, 5:26 AM
hokein marked 3 inline comments as done.

Address comments.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2019, 5:30 AM