Details
Details
- Reviewers
philip.pfaffe chandlerc fedor.sergeev
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 34546 Build 34545: arc lint + arc unit
Event Timeline
Comment Actions
Minor drive-by stylistic points. Someone who knows what's going on with passes should look at this.
llvm/include/llvm/CodeGen/MachineCopyPropagation.h | ||
---|---|---|
1 | This line needs the 'C++' tag, see any other .h file for an example. | |
llvm/lib/CodeGen/CodeGen.cpp | ||
62 | This wants to stay in alphabetical order. | |
llvm/lib/CodeGen/MachineCopyPropagation.cpp | ||
634 | Did you mean for this to be a static function? | |
llvm/lib/Passes/PassRegistry.def | ||
315 | Based on the style in this file, there wants to be a blank line before the '#ifndef'. |
This line needs the 'C++' tag, see any other .h file for an example.