Page MenuHomePhabricator

[NewPM] Port MachineCopyPropagation to the new pass manager.
Needs ReviewPublic

Authored by czhang on Jul 3 2019, 6:35 PM.

Event Timeline

czhang created this revision.Jul 3 2019, 6:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2019, 6:35 PM
czhang updated this revision to Diff 208557.Jul 8 2019, 5:48 PM

rebase & clang-format

Minor drive-by stylistic points. Someone who knows what's going on with passes should look at this.

llvm/include/llvm/CodeGen/MachineCopyPropagation.h
2

This line needs the 'C++' tag, see any other .h file for an example.

llvm/lib/CodeGen/CodeGen.cpp
63

This wants to stay in alphabetical order.

llvm/lib/CodeGen/MachineCopyPropagation.cpp
634–637

Did you mean for this to be a static function?

llvm/lib/Passes/PassRegistry.def
315

Based on the style in this file, there wants to be a blank line before the '#ifndef'.

czhang updated this revision to Diff 208720.Jul 9 2019, 9:53 AM

Rebase & address style comments.

czhang updated this revision to Diff 208728.Jul 9 2019, 10:01 AM
czhang marked 2 inline comments as done.

another style comment

czhang marked 2 inline comments as done.Jul 9 2019, 10:01 AM
lenary added a subscriber: lenary.Jul 12 2019, 1:29 AM