[lldb_test_suite] Fix lldb test suite targeting remote Android

[kusmour]

Summary

Fixed Android.rules for running test suite on remote android

• the build configuration is not compatible with ndk structure, change it to link to static libc++
• generally clang should be able to use libc++ and will link against the right library, but some libc++ installations require the user manually link libc++abi.
• add flag -lc++abi to fix the test binary build failure

Added skipIfTargetAndroid skipUnlessTargetAndroid for better test support

• the skipIfPlatform method will ask lldbplatformutil.getPlatform() for platform info which is actually the os type, and Android is not os type but environment
• create this function to handle the android target condition

To Run Test on Remote Android
1 start lldb-server on your devices
2 run lldb-dotest with following configuration:
./lldb-dotest --out-of-tree-debugserver --arch aarch64 --platform-name remote-android --platform-url connect://localhost:12345 --platform-working-dir /data/local/tmp/ --compiler your/ndk/clang

[xiaobai]

This patch looks fine to me overall. I'm unsure if LLDB has a guarantee about which NDK version its compatible with, but I'm alright with staying up to date with the latest release

@labath: Maybe you'd be interested in this patch as well? I'm not sure who actually still works on android debugging at Google.

@kusmour: This patch doesn't have enough context with each change. Try getting the change with git diff -U9999 or something like that for the entire context.

[srhines]

lldb/packages/Python/lldbsuite/test/make/Android.rules

93 ↗

(On Diff #207701)

This line could just be -lc++_static now for more simplicity (much like the next line).

[labath]

In D64118#1568656, @xiaobai wrote:

This patch looks fine to me overall. I'm unsure if LLDB has a guarantee about which NDK version its compatible with, but I'm alright with staying up to date with the latest release

Yeah, that been my general objective while I was still working on android...

@labath: Maybe you'd be interested in this patch as well? I'm not sure who actually still works on android debugging at Google.

The patch looks fine to me. I am also not sure who still works on android debugging at Google :(, but I am glad that at least you guys are. :)

[kusmour]

added method skipIfTargetAndroid

lldb/trunk/packages/Python/lldbsuite/test/android/platform/TestDefaultCacheLineSize.py

 from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbutil
 
 
 class DefaultCacheLineSizeTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @skipUnlessPlatform(['android'])
+    @skipUnlessTargetAndroid
     def test_cache_line_size(self):
         self.build(dictionary=self.getBuildFlags())
         exe = self.getBuildArtifact("a.out")
         target = self.dbg.CreateTarget(exe)
         self.assertTrue(target and target.IsValid(), "Target is valid")
 
         breakpoint = target.BreakpointCreateByName("main")
         self.assertTrue(

lldb/trunk/packages/Python/lldbsuite/test/decorators.py

def skipIfLinux(func):
     """Decorate the item to skip tests that should be skipped on Linux."""
     return skipIfPlatform(["linux"])(func)
 
 
 def skipIfWindows(func):
     """Decorate the item to skip tests that should be skipped on Windows."""
     return skipIfPlatform(["windows"])(func)
 
+def skipIfTargetAndroid(func):
+    return unittest2.skipIf(lldbplatformutil.target_is_android(),
+                                "skip on target Android")(func)
+
 
 def skipUnlessWindows(func):
     """Decorate the item to skip tests that should be skipped on any non-Windows platform."""
     return skipUnlessPlatform(["windows"])(func)
 
 
 def skipUnlessDarwin(func):
     """Decorate the item to skip tests that should be skipped on any non Darwin platform."""
     return skipUnlessPlatform(lldbplatformutil.getDarwinOSTriples())(func)
 
+def skipUnlessTargetAndroid(func):
+    return unittest2.skipUnless(lldbplatformutil.target_is_android(),
+                                "requires target to be Android")(func)
+
 
 def skipIfHostIncompatibleWithRemote(func):
     """Decorate the item to skip tests if binaries built on this host are incompatible."""
 
     def is_host_incompatible_with_remote(self):
         host_arch = self.getLldbArchitecture()
         host_platform = lldbplatformutil.getHostPlatform()
         target_arch = self.getArchitecture()

lldb/trunk/packages/Python/lldbsuite/test/make/Android.rules

 else
   ARCH_CXXFLAGS += \
     -isystem $(NDK_ROOT)/sources/cxx-stl/llvm-libc++/include \
     -isystem $(NDK_ROOT)/sources/android/support/include \
     -isystem $(NDK_ROOT)/sources/cxx-stl/llvm-libc++abi/include
 
   ARCH_LDFLAGS += \
     -L$(NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/$(STL_ARCH) \
-    $(NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/$(STL_ARCH)/libc++.a
+    $(NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/$(STL_ARCH)/libc++_static.a \
+    -lc++abi
 endif