Page MenuHomePhabricator

kusmour (Wanyi Ye)
User

Projects

User does not belong to any projects.

User Details

User Since
May 20 2019, 6:56 PM (8 w, 2 d)

Recent Activity

Tue, Jul 16

kusmour added a comment to D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64.

Whether a lot of these tests (e.g. all watchpoint related tests) pass or fail may depend on the exact android device you are running the tests against. However, you are the only ones running android tests ATM, so that does not matter much right now. If that ever changes, we'll have to do something smarter here...

Tue, Jul 16, 11:12 AM · Restricted Project
kusmour added a comment to D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule.

The change is fine, but for my own education, could you elaborate on what this "delayed calculation" is, and how does it make the test fail?

Tue, Jul 16, 11:09 AM · Restricted Project

Mon, Jul 15

kusmour created D64771: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up.
Mon, Jul 15, 1:53 PM · Restricted Project
kusmour created D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule.
Mon, Jul 15, 1:53 PM · Restricted Project
kusmour created D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64.
Mon, Jul 15, 1:45 PM · Restricted Project

Thu, Jul 11

kusmour updated the diff for D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator.

add more context to diff

Thu, Jul 11, 1:59 PM · Restricted Project
kusmour created D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator.
Thu, Jul 11, 12:27 PM · Restricted Project

Tue, Jul 9

kusmour created D64434: [lldb] Quick Fix: IRExecutionUnit check pointer before access it.
Tue, Jul 9, 11:48 AM · Restricted Project, Restricted Project

Mon, Jul 8

kusmour updated the diff for D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android.

added method skipIfTargetAndroid

Mon, Jul 8, 11:30 AM · Restricted Project, Restricted Project

Tue, Jul 2

kusmour updated the summary of D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android.
Tue, Jul 2, 8:26 PM · Restricted Project, Restricted Project
kusmour updated the summary of D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android.
Tue, Jul 2, 8:14 PM · Restricted Project, Restricted Project
kusmour created D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android.
Tue, Jul 2, 8:10 PM · Restricted Project, Restricted Project

Wed, Jun 19

kusmour updated the diff for D62213: [ABI] Implement Windows ABI for x86_64.

allow SysV_x86_64 ABI to handle unknown OS type
this should fix the test SymbolFile/DWARF/debug_loc.s

Wed, Jun 19, 10:57 AM · Restricted Project, Restricted Project

Jun 18 2019

kusmour added a comment to D62213: [ABI] Implement Windows ABI for x86_64.

@labath Hi, you're right about the lld, it didn't make the test pass, instead it became unsupported.

Jun 18 2019, 2:50 PM · Restricted Project, Restricted Project
kusmour updated the diff for D62213: [ABI] Implement Windows ABI for x86_64.

the OS check in SysV x64 ABI broke the test SymbolFile/DWARF/debug_loc.s
added a restriction lld to #REQUIRES

Jun 18 2019, 10:35 AM · Restricted Project, Restricted Project

Jun 14 2019

kusmour updated the diff for D62213: [ABI] Implement Windows ABI for x86_64.

complete the code for floating point registers and cleaned up
the support for floating point registers fixed TestRegistersIterator update the testcased

Jun 14 2019, 5:15 PM · Restricted Project, Restricted Project

Jun 13 2019

kusmour updated the diff for D62213: [ABI] Implement Windows ABI for x86_64.

Added support for XMM registers.
Now the step out on a function returns floating point number should have the right value.
To play with it, define a function

float getFloat(float value) {
    return value;
}

set a break point and step out
LLDB will print out the right value if debugging on Windows-x86_64

Jun 13 2019, 10:03 PM · Restricted Project, Restricted Project

Jun 4 2019

kusmour updated the diff for D62213: [ABI] Implement Windows ABI for x86_64.

Update the GetReturnValueObjectImpl using function CanPassInRegisters to explicitly check

NOTE: There's NO register context info about registers beyond general purpose registers So floating point return type is not supported since it uses XMM0 to return need to update register context for windows x64
Jun 4 2019, 7:55 PM · Restricted Project, Restricted Project

Jun 3 2019

kusmour updated the diff for D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.
  1. Limit the TestReturnValue for nested struct and class (cpp support) to only x86_64
  2. This patch somehow fix the bug: pr36870 for Systerm V ABI (windows is waiting for this change to go in). So I change the test to allow passing on SysV-x86_64
Jun 3 2019, 5:05 PM · Restricted Project, Restricted Project
kusmour abandoned D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb.

D62772 toke care of this

Jun 3 2019, 10:40 AM · Restricted Project

Jun 1 2019

kusmour added inline comments to D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb.
Jun 1 2019, 10:29 PM · Restricted Project
kusmour updated the diff for D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb.

fix switch statement

Jun 1 2019, 10:29 PM · Restricted Project
kusmour added inline comments to D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.
Jun 1 2019, 4:55 PM · Restricted Project, Restricted Project
kusmour updated the diff for D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.

small update :)

Jun 1 2019, 4:55 PM · Restricted Project, Restricted Project
kusmour retitled D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb from [LLDBregisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb to [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb.
Jun 1 2019, 1:24 AM · Restricted Project
kusmour created D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb.
Jun 1 2019, 12:20 AM · Restricted Project

May 31 2019

kusmour updated the diff for D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.

added a virtual function CanPassInRegister in TypeSystem class
to provide info about type can be passed in register or not
ClangASTContext will refer to clang::RecordDecl::canPassInRegister for this info
and later SwiftASTContext can provide the equivalent
updated the test to test on C++
and provided class test, including base class, subclass, abstract class (this one must be in memory)

May 31 2019, 5:58 PM · Restricted Project, Restricted Project
kusmour added a comment to D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.

Actually, I think that we should extend CompilerType and TypeSystem to expose Clang's knowledge of whether a type is passed in a register by means of using clang::RecordDecl::isPassInRegisters

May 31 2019, 2:49 PM · Restricted Project, Restricted Project

May 30 2019

kusmour updated the diff for D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.

simplify the method in 'FlattenAggregateType'
added test for nested struct returned in registers

May 30 2019, 5:43 PM · Restricted Project, Restricted Project
kusmour added inline comments to D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.
May 30 2019, 4:53 PM · Restricted Project, Restricted Project
kusmour added a comment to D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.

@jingham working on the unit test rn. will upload soon

May 30 2019, 2:09 PM · Restricted Project, Restricted Project
kusmour created D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.
May 30 2019, 1:53 PM · Restricted Project, Restricted Project

May 24 2019

kusmour updated the diff for D62213: [ABI] Implement Windows ABI for x86_64.

update the CreateDefaultUnwindPlan.
return false or give empty Unwind Plan may cause lldb to crash and break tests on windows.
So for now, copy the SysV-x86_64

May 24 2019, 6:27 PM · Restricted Project, Restricted Project

May 22 2019

kusmour updated the diff for D62213: [ABI] Implement Windows ABI for x86_64.

update nit

May 22 2019, 5:22 PM · Restricted Project, Restricted Project
kusmour added inline comments to D62213: [ABI] Implement Windows ABI for x86_64.
May 22 2019, 5:19 PM · Restricted Project, Restricted Project

May 21 2019

kusmour added inline comments to D62213: [ABI] Implement Windows ABI for x86_64.
May 21 2019, 6:31 PM · Restricted Project, Restricted Project
kusmour updated the diff for D62213: [ABI] Implement Windows ABI for x86_64.

update a new version based on comment.
cleaned some useless comment
change to use CHAR_BIT for readability

May 21 2019, 6:10 PM · Restricted Project, Restricted Project
kusmour created D62213: [ABI] Implement Windows ABI for x86_64.
May 21 2019, 11:26 AM · Restricted Project, Restricted Project