[windows] re-call signal in sigint_handler for Windows

[lanza]

Summary

Windows requires re-setting the signal handler each time it is used
and thus ctrl-c was not behaving properly on Windows

[jfb]

tools/driver/Driver.cpp

711

It seems like you'd want to do it for every non-fatal signal, not just signint?

[lanza]

tools/driver/Driver.cpp

711

  signal(SIGINT, sigint_handler);
#if !defined(_MSC_VER)
  signal(SIGPIPE, SIG_IGN);
  signal(SIGWINCH, sigwinch_handler);
  signal(SIGTSTP, sigtstp_handler);
  signal(SIGCONT, sigcont_handler);
#endif

Windows doesn't have them, thus they re ifdefed out.

[stella.stamenova]

LGTM. Have you run the tests to make sure they behave correctly after this change?

[lanza]

rebase

tools/driver/Driver.cpp

if ((isatty(STDIN_FILENO) != 0) &&
       ::ioctl(STDIN_FILENO, TIOCGWINSZ, &window_size) == 0) {
     if ((window_size.ws_col > 0) && g_driver != nullptr) {
       g_driver->ResizeWindow(window_size.ws_col);
     }
   }
 }
 
 void sigint_handler(int signo) {
+#ifdef _WIN32 // Restore handler as it is not persistent on Windows
+  signal(SIGINT, sigint_handler);
+#endif
   static std::atomic_flag g_interrupt_sent = ATOMIC_FLAG_INIT;
   if (g_driver != nullptr) {
     if (!g_interrupt_sent.test_and_set()) {
       g_driver->GetDebugger().DispatchInputInterrupt();
       g_interrupt_sent.clear();
       return;
     }
   }