Page MenuHomePhabricator
Differential D64030

[analyzer] Support kfree in MallocChecker
ClosedPublic
Actions

Authored by Nathan-Huckleberry on Jul 1 2019, 12:59 PM.

Details

Reviewers
NoQ
nickdesaulniers
dcoughlin
Szelethus
Commits
rL364875: [analyzer] Support kfree in MallocChecker
rG121401425d4d: [analyzer] Support kfree in MallocChecker
rC364875: [analyzer] Support kfree in MallocChecker
Summary

kmalloc is freed with kfree in the linux kernel. kmalloc support was
added in r204832, but kfree was not. Adding kfree fixes incorrectly
detected memory leaks.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 12:59 PM
Herald added subscribers: cfe-commits, Charusso, dkrupp and 7 others. · View Herald Transcript
jordan_rose resigned from this revision.Jul 1 2019, 1:07 PM
jordan_rose edited reviewers, added: dcoughlin; removed: jordan_rose.
NoQ accepted this revision.Jul 1 2019, 1:07 PM

Whoops. Thanks!!

This revision is now accepted and ready to land.Jul 1 2019, 1:07 PM
Szelethus accepted this revision.Jul 1 2019, 3:26 PM

Nice.

Closed by commit rL364875: [analyzer] Support kfree in MallocChecker (authored by Nathan-Huckleberry, committed by ). · Explain WhyJul 1 2019, 4:34 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 4:35 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents
Changeset List

Diff 207439

View Options

cfe/trunk/lib/StaticAnalyzer/Checkers/MallocChecker.cpp

Loading...
View Options

cfe/trunk/test/Analysis/kmalloc-linux.c

Loading...