Page MenuHomePhabricator

Nathan-Huckleberry (Nathan Huckleberry)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 14 2019, 3:51 PM (18 w, 4 d)

Recent Activity

Aug 23 2019

Nathan-Huckleberry committed rGcc01d6421f4a: [Sema] Don't warn on printf('%hd', [char]) (PR41467) (authored by Nathan-Huckleberry).
[Sema] Don't warn on printf('%hd', [char]) (PR41467)
Aug 23 2019, 11:04 AM
Nathan-Huckleberry committed rL369791: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
[Sema] Don't warn on printf('%hd', [char]) (PR41467)
Aug 23 2019, 11:04 AM
Nathan-Huckleberry closed D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
Aug 23 2019, 11:04 AM · Restricted Project, Restricted Project
Nathan-Huckleberry committed rG5808077bc68b: Allow Compiler.h to be included in C files and fix fallthrough warnings (authored by Nathan-Huckleberry).
Allow Compiler.h to be included in C files and fix fallthrough warnings
Aug 23 2019, 10:27 AM
Nathan-Huckleberry committed rL369782: Allow Compiler.h to be included in C files and fix fallthrough warnings.
Allow Compiler.h to be included in C files and fix fallthrough warnings
Aug 23 2019, 10:26 AM
Nathan-Huckleberry closed D66609: Allow Compiler.h to be included in C files and fix fallthrough warnings.
Aug 23 2019, 10:26 AM · Restricted Project
Nathan-Huckleberry updated the diff for D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
  • Add if without else
Aug 23 2019, 10:21 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
  • Remove else
Aug 23 2019, 10:10 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D66609: Allow Compiler.h to be included in C files and fix fallthrough warnings.
  • Fix comment
Aug 23 2019, 10:10 AM · Restricted Project

Aug 22 2019

Nathan-Huckleberry updated the diff for D66609: Allow Compiler.h to be included in C files and fix fallthrough warnings.
  • Clarify comments
Aug 22 2019, 4:42 PM · Restricted Project
Nathan-Huckleberry updated the diff for D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
  • Simplify logic for readability
Aug 22 2019, 4:40 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
  • Fix broken logic from previous revision
Aug 22 2019, 4:15 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
  • Remove else and |=
Aug 22 2019, 3:56 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added inline comments to D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
Aug 22 2019, 3:56 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added inline comments to D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
Aug 22 2019, 3:56 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added inline comments to D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
Aug 22 2019, 3:56 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
  • Add variable for implicit match and fix comments
Aug 22 2019, 2:08 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D66609: Allow Compiler.h to be included in C files and fix fallthrough warnings.
  • Add comment and remove direct use of __has_cpp_attribute
Aug 22 2019, 1:57 PM · Restricted Project
Nathan-Huckleberry updated the diff for D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
  • Cleanup test
Aug 22 2019, 1:43 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
  • Warn when -Wformat-pedantic is set
Aug 22 2019, 1:32 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added reviewers for D66609: Allow Compiler.h to be included in C files and fix fallthrough warnings: nickdesaulniers, aaron.ballman, xbolva00.
Aug 22 2019, 11:15 AM · Restricted Project
Nathan-Huckleberry created D66609: Allow Compiler.h to be included in C files and fix fallthrough warnings.
Aug 22 2019, 11:15 AM · Restricted Project
Nathan-Huckleberry added a comment to D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.

New patch: https://reviews.llvm.org/D66609

Aug 22 2019, 11:15 AM · Restricted Project

Aug 21 2019

Nathan-Huckleberry added a comment to D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.

Maybe replace __has_cpp_attribute with something like this?

#ifndef has_cpp_attribute
#ifdef __cplusplus
# define has_cpp_attribute(x) __has_cpp_attribute(x)
#else
# define has_cpp_attribute(x) 0
#endif
#endif

That will run into the same issue -- you'll use has_cpp_attribute(clang::something) and in non-C++ mode, the :: will cause an error. You need to hide the :: behind the __cplusplus check.

Shouldn't the preprocessor take care of that? has_cpp_attribute(clang::something) just gets replaced by 0? I tested locally and it appears to work.

Aug 21 2019, 3:06 PM · Restricted Project
Nathan-Huckleberry updated the summary of D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Aug 21 2019, 1:44 PM · Restricted Project
Nathan-Huckleberry added a comment to D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.

Maybe replace __has_cpp_attribute with something like this?

Aug 21 2019, 1:41 PM · Restricted Project
Nathan-Huckleberry committed rG01a413695c98: Fix -Wimplicit-fallthrough warnings in regcomp.c (authored by Nathan-Huckleberry).
Fix -Wimplicit-fallthrough warnings in regcomp.c
Aug 21 2019, 10:12 AM
Nathan-Huckleberry committed rL369549: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Fix -Wimplicit-fallthrough warnings in regcomp.c
Aug 21 2019, 10:06 AM
Nathan-Huckleberry closed D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Aug 21 2019, 10:06 AM · Restricted Project

Aug 20 2019

Nathan-Huckleberry updated the diff for D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
  • Change if to ifdef
Aug 20 2019, 2:54 PM · Restricted Project
Nathan-Huckleberry updated the diff for D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
  • Code cleanup
Aug 20 2019, 2:03 PM · Restricted Project
Nathan-Huckleberry updated the diff for D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
  • Add attribute to compiler.h
Aug 20 2019, 1:00 PM · Restricted Project
Nathan-Huckleberry added inline comments to D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Aug 20 2019, 12:36 PM · Restricted Project
Nathan-Huckleberry created D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Aug 20 2019, 11:20 AM · Restricted Project
Nathan-Huckleberry added a reviewer for D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c: aaron.ballman.
Aug 20 2019, 11:20 AM · Restricted Project
Nathan-Huckleberry committed rG1e0affb6e564: [Attr] Support _attribute__ ((fallthrough)) (authored by Nathan-Huckleberry).
[Attr] Support _attribute__ ((fallthrough))
Aug 20 2019, 10:17 AM
Nathan-Huckleberry committed rL369414: [Attr] Support _attribute__ ((fallthrough)).
[Attr] Support _attribute__ ((fallthrough))
Aug 20 2019, 10:16 AM
Nathan-Huckleberry closed D64838: [Attr] Support _attribute__ ((fallthrough)).
Aug 20 2019, 10:16 AM · Restricted Project, Restricted Project

Aug 16 2019

Nathan-Huckleberry added inline comments to D63889: Check possible warnings on global initializers for reachability.
Aug 16 2019, 3:54 PM · Restricted Project
Nathan-Huckleberry updated the diff for D63889: Check possible warnings on global initializers for reachability.
  • Use ExprEvalContext and remove mangling context code
Aug 16 2019, 3:49 PM · Restricted Project

Aug 15 2019

Nathan-Huckleberry added a comment to D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).

As far as I can tell this case was just overlooked. The original commit adding this change https://reviews.llvm.org/rG0208793e41018ac168412a3da8b2fba70aba9716 only allows chars to int and chars to chars. Another commit ignores typing of chars https://reviews.llvm.org/rG74e82bd190017d59d5d78b07dedca5b06b4547da. I did not see anything related to this particular case in previous commits.

Aug 15 2019, 4:50 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added a comment to D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).

There was a request in the linked bug for some code archaeology to see why this behavior exists in the first place. What were the results of that? I'm not opposed to the patch, but I would like to understand why it behaves the way it does.

Aug 15 2019, 11:05 AM · Restricted Project, Restricted Project

Aug 13 2019

Nathan-Huckleberry updated the diff for D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
  • Add comment in test
Aug 13 2019, 4:16 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added a reviewer for D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467): rsmith.
Aug 13 2019, 4:13 PM · Restricted Project, Restricted Project
Nathan-Huckleberry created D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
Aug 13 2019, 4:13 PM · Restricted Project, Restricted Project

Aug 6 2019

Nathan-Huckleberry created D65828: [clang-tidy] Add check to linuxkernel for unbalanced irq calls.
Aug 6 2019, 2:06 PM · Restricted Project, Restricted Project

Aug 5 2019

Nathan-Huckleberry added inline comments to D63889: Check possible warnings on global initializers for reachability.
Aug 5 2019, 4:38 PM · Restricted Project
Nathan-Huckleberry updated the diff for D64838: [Attr] Support _attribute__ ((fallthrough)).
  • Remove 'maybe', remove boolean and fix other call to ParseSimpleDeclaration
Aug 5 2019, 12:42 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64838: [Attr] Support _attribute__ ((fallthrough)).
  • Remove changes from accidentally formatted files
Aug 5 2019, 11:04 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64838: [Attr] Support _attribute__ ((fallthrough)).
  • Allow decl-specifier source location to propagate to decl parsing
Aug 5 2019, 10:56 AM · Restricted Project, Restricted Project

Aug 2 2019

Nathan-Huckleberry committed rG6722923c3883: [clang-tidy] Adding static analyzer check to list of clang-tidy checks (authored by Nathan-Huckleberry).
[clang-tidy] Adding static analyzer check to list of clang-tidy checks
Aug 2 2019, 10:20 AM
Nathan-Huckleberry committed rL367694: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
[clang-tidy] Adding static analyzer check to list of clang-tidy checks
Aug 2 2019, 10:20 AM
Nathan-Huckleberry closed D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
Aug 2 2019, 10:20 AM · Restricted Project, Restricted Project

Aug 1 2019

Nathan-Huckleberry updated the diff for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
  • Support python2
Aug 1 2019, 1:02 PM · Restricted Project, Restricted Project

Jul 29 2019

Nathan-Huckleberry updated the diff for D64838: [Attr] Support _attribute__ ((fallthrough)).
  • Fix test case spacing
Jul 29 2019, 10:50 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64838: [Attr] Support _attribute__ ((fallthrough)).
  • Fix test, formatting and conditional check
Jul 29 2019, 10:15 AM · Restricted Project, Restricted Project

Jul 26 2019

Nathan-Huckleberry updated the diff for D64838: [Attr] Support _attribute__ ((fallthrough)).
  • Rework attribute parsing
Jul 26 2019, 2:58 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64838: [Attr] Support _attribute__ ((fallthrough)).
  • Formatting fixes
Jul 26 2019, 2:58 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
  • Order swap and elif
Jul 26 2019, 12:44 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
  • Add in-tree as possible default location
Jul 26 2019, 10:47 AM · Restricted Project, Restricted Project
Nathan-Huckleberry committed rG2e040398f8d6: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression (authored by Nathan-Huckleberry).
[Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression
Jul 26 2019, 10:30 AM
Nathan-Huckleberry committed rL367134: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
[Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression
Jul 26 2019, 10:30 AM
Nathan-Huckleberry closed D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
Jul 26 2019, 10:29 AM · Restricted Project, Restricted Project
Nathan-Huckleberry added a comment to D64838: [Attr] Support _attribute__ ((fallthrough)).

I agree that parsing according to attribute name/type is not a good solution.

Jul 26 2019, 10:28 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
  • Make filepath optionally user specified
Jul 26 2019, 10:05 AM · Restricted Project, Restricted Project

Jul 24 2019

Nathan-Huckleberry updated the diff for D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
  • Add comment
Jul 24 2019, 10:12 AM · Restricted Project, Restricted Project

Jul 23 2019

Nathan-Huckleberry added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

I think this looks reasonable to me, though I am still not certain if the relative path in the python script will work with both the svn in-tree directory layout as well as the git monorepo layout (which I'm far less familiar with).

Jul 23 2019, 2:50 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added a comment to D64838: [Attr] Support _attribute__ ((fallthrough)).
void foo() {
  __attribute__((address_space(0))) *x;
  *y;
}

If the attributes are parsed then function body looks like this to the parser:

{
  *x; //this one has attributes now
  *y;
{

The first line should be a valid declaration and the second like should be a dereference of an uninitialized variable. If the attributes token is discarded before parsing the rest of the line the only way to differentiate these is by looking at the attributes added to them.

An alternative may be parse the attributes list and immediately try to parse as a declaration then if that parsing fails attempt to parse as something else. Although this approach also has the scary implication of things that are supposed to be declarations getting reparsed as something entirely different.

The issue is that a leading GNU-style attribute is not sufficient information to determine whether we're parsing a declaration or a statement; it shouldn't always be treated as a decl-specifier. I spoke with a GCC dev about how they handle this, and effectively, they parse the attributes first then attempt to parse a declaration; if that fails, they fall back to parsing a statement. I think the way forward for us that should be similar is to parse the attributes first and then wait until we see a decl-specifier before determining whether we want to parse a declaration or a statement, and attach the attributes after we've figured out which production we have. @rsmith may have even better approaches in mind, but we're definitely agreed that we should not parse statement/decl based on attribute identity. I would hope we could find a way to avoid lots of re-parsing work if we can (even to the point of perhaps breaking the address_space case because implicit int is pretty horrible to rely on in the first place; it depends on whether breaking that will break a lot of code or not).

Jul 23 2019, 10:14 AM · Restricted Project, Restricted Project

Jul 22 2019

Nathan-Huckleberry updated the diff for D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
  • Disable self reference checking for C
Jul 22 2019, 4:42 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D63889: Check possible warnings on global initializers for reachability.
  • Style fixes
Jul 22 2019, 4:11 PM · Restricted Project
Nathan-Huckleberry updated the diff for D63889: Check possible warnings on global initializers for reachability.
  • Style fixes
Jul 22 2019, 4:03 PM · Restricted Project
Nathan-Huckleberry updated the diff for D63889: Check possible warnings on global initializers for reachability.
  • Add tracking of declaration of initializers in Sema.
Jul 22 2019, 3:23 PM · Restricted Project

Jul 18 2019

Nathan-Huckleberry added a comment to D64838: [Attr] Support _attribute__ ((fallthrough)).
void foo() {
  __attribute__((address_space(0))) *x;
  *y;
}

If the attributes are parsed then function body looks like this to the parser:

{
  *x; //this one has attributes now
  *y;
{

The first line should be a valid declaration and the second like should be a dereference of an uninitialized variable. If the attributes token is discarded before parsing the rest of the line the only way to differentiate these is by looking at the attributes added to them.

Jul 18 2019, 3:58 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added a comment to D64838: [Attr] Support _attribute__ ((fallthrough)).

The main problem that we have is that the __attribute__ token always causes the parser to read the line as a declaration. Then the declaration parser handles reading the attributes list.

This case demonstrates the problem:

void foo() {
  __attribute__((address_space(0))) *x;
}

If the attribute token is read beforehand this code just becomes *x and is parsed as a dereference of an undefined variable when it should actually be a declaration.

Maybe the best solution is to pull the attributes parsing out to ParseStatementOrDeclaration then pass those attributes through to following functions.
When the determination is made whether a line is a declaration or a statement the attributes list can be looked at to determine if the attributes are statement or declaration attributes and continue accordingly. Maybe throwing a warning if mixing of declaration and statement attributes occur.

Does that sound like a good solution?

Please see the discussion in https://reviews.llvm.org/D63299#inline-564887 -- if I understand your approach properly, this approach leads to spooky action at a distance, where the name of the attribute dictates whether something is a statement or a declaration. I'm not comfortable with that. There's no reason we could not have an attribute that is both a statement attribute and a declaration attribute, and how would *that* parse?

I think this requires some deeper surgery in the parsing logic so that attributes do not impact whether something is treated as a declaration or a statement. The parser should parse attributes first, keep them around for a while, and attach them to either the decl or the statement at a later point.

Jul 18 2019, 11:37 AM · Restricted Project, Restricted Project

Jul 17 2019

Nathan-Huckleberry committed rGb53e13cd43e8: [clang-tidy] Fix crash on end location inside macro (authored by Nathan-Huckleberry).
[clang-tidy] Fix crash on end location inside macro
Jul 17 2019, 10:23 AM
Nathan-Huckleberry committed rL366353: [clang-tidy] Fix crash on end location inside macro.
[clang-tidy] Fix crash on end location inside macro
Jul 17 2019, 10:22 AM
Nathan-Huckleberry closed D64607: [clang-tidy] Fix crash on end location inside macro.
Jul 17 2019, 10:22 AM · Restricted Project, Restricted Project
Nathan-Huckleberry added a comment to D64838: [Attr] Support _attribute__ ((fallthrough)).

The main problem that we have is that the __attribute__ token always causes the parser to read the line as a declaration. Then the declaration parser handles reading the attributes list.

Jul 17 2019, 10:15 AM · Restricted Project, Restricted Project

Jul 16 2019

Nathan-Huckleberry added reviewers for D64838: [Attr] Support _attribute__ ((fallthrough)): aaron.ballman, rsmith, efriedma.
Jul 16 2019, 4:13 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64838: [Attr] Support _attribute__ ((fallthrough)).
  • Fixed formatting
Jul 16 2019, 4:12 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added a comment to D64838: [Attr] Support _attribute__ ((fallthrough)).

Revival of https://reviews.llvm.org/D63260 and https://reviews.llvm.org/D63299.

Jul 16 2019, 4:12 PM · Restricted Project, Restricted Project
Nathan-Huckleberry created D64838: [Attr] Support _attribute__ ((fallthrough)).
Jul 16 2019, 4:07 PM · Restricted Project, Restricted Project

Jul 15 2019

Nathan-Huckleberry added inline comments to D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
Jul 15 2019, 10:40 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
  • Change cast type
Jul 15 2019, 10:39 AM · Restricted Project, Restricted Project

Jul 12 2019

Nathan-Huckleberry updated the diff for D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
  • Add warning-free test cases
Jul 12 2019, 4:53 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the summary of D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
Jul 12 2019, 4:37 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
  • Fixed style
Jul 12 2019, 4:21 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
  • Adding fix
Jul 12 2019, 4:20 PM · Restricted Project, Restricted Project
Nathan-Huckleberry created D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression.
Jul 12 2019, 4:19 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
  • Forgot to fix list.rst
Jul 12 2019, 4:18 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
  • Added script for generation of docs based off Checkers.td
  • Updated to match newly standardized anchor urls
  • Add auto redirect and remove alpha checkers
Jul 12 2019, 4:14 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
  • Add auto redirect and remove alpha checkers
Jul 12 2019, 10:56 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64607: [clang-tidy] Fix crash on end location inside macro.
  • Add test
Jul 12 2019, 10:22 AM · Restricted Project, Restricted Project

Jul 11 2019

Nathan-Huckleberry updated subscribers of D64607: [clang-tidy] Fix crash on end location inside macro.
Jul 11 2019, 5:30 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64607: [clang-tidy] Fix crash on end location inside macro.
  • Ran git-clang-format
Jul 11 2019, 5:30 PM · Restricted Project, Restricted Project
Nathan-Huckleberry added reviewers for D64607: [clang-tidy] Fix crash on end location inside macro: JonasToth, aaron.ballman.
Jul 11 2019, 5:28 PM · Restricted Project, Restricted Project
Nathan-Huckleberry created D64607: [clang-tidy] Fix crash on end location inside macro.
Jul 11 2019, 5:27 PM · Restricted Project, Restricted Project
Nathan-Huckleberry updated subscribers of D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
Jul 11 2019, 10:53 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
  • Fix style on comments in script
Jul 11 2019, 10:51 AM · Restricted Project, Restricted Project
Nathan-Huckleberry updated the diff for D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
  • Added script for generation of docs based off Checkers.td
  • Updated to match newly standardized anchor urls
Jul 11 2019, 10:48 AM · Restricted Project, Restricted Project