jordan_rose (Jordan Rose)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 29 2012, 11:21 AM (303 w, 16 h)

Recent Activity

Mon, Jun 18

jordan_rose added inline comments to D38833: BitstreamWriter: Better assertion when a block's abbrev code size is too small.
Mon, Jun 18, 9:54 AM
jordan_rose requested review of D38833: BitstreamWriter: Better assertion when a block's abbrev code size is too small.

Thanks, Roman. Too bad this is such a stable piece of LLVM, or else I'd have more people qualified to review!

Mon, Jun 18, 8:47 AM

Fri, Jun 15

jordan_rose added a reviewer for D48251: Assert on implicit truncation in llvm::endian::Writer: zturner.
Fri, Jun 15, 6:01 PM
jordan_rose created D48251: Assert on implicit truncation in llvm::endian::Writer.
Fri, Jun 15, 6:00 PM
jordan_rose closed D48197: Avoid copying PrettyStackTrace messages an extra time on Apple platforms.

Committed in rL334841.

Fri, Jun 15, 9:40 AM

Thu, Jun 14

jordan_rose created D48197: Avoid copying PrettyStackTrace messages an extra time on Apple platforms.
Thu, Jun 14, 2:12 PM
jordan_rose added inline comments to D38833: BitstreamWriter: Better assertion when a block's abbrev code size is too small.
Thu, Jun 14, 9:30 AM

Wed, Jun 13

jordan_rose updated the diff for D38833: BitstreamWriter: Better assertion when a block's abbrev code size is too small.

Took recommendation about the form of the check, pumped up the tests.

Wed, Jun 13, 7:23 PM
jordan_rose added inline comments to D38833: BitstreamWriter: Better assertion when a block's abbrev code size is too small.
Wed, Jun 13, 2:07 PM
jordan_rose added inline comments to D38833: BitstreamWriter: Better assertion when a block's abbrev code size is too small.
Wed, Jun 13, 2:06 PM
jordan_rose closed D48108: Handle an Xcode path with spaces in it.

Landed in rL334632. Turns out the iOS.cmake part has been refactored since the version I was looking at (Swift 4.2's branch of LLVM), and so this was just the libtool change.

Wed, Jun 13, 11:29 AM
jordan_rose added a reviewer for D38833: BitstreamWriter: Better assertion when a block's abbrev code size is too small: tejohnson.

Reviving this old review. I'd like *someone* to tell me I didn't miss something.

Wed, Jun 13, 9:40 AM

Tue, Jun 12

jordan_rose created D48108: Handle an Xcode path with spaces in it.
Tue, Jun 12, 4:57 PM

May 7 2018

jordan_rose closed D44317: Delete the copy constructor for llvm::yaml::Node.

Landed in rL328345.

May 7 2018, 2:49 PM

Apr 9 2018

jordan_rose added a comment to D45140: [Support] Change std::sort to llvm::sort in response to r327219.

Exactly that's what I thought too, and llvm::sort already accepts a range (Container.begin(), Container.end()). In that case, could you please clarify what exactly do you mean by a "range-based variant" and its use cases in LLVM?

Apr 9 2018, 11:41 AM
jordan_rose added a comment to D45140: [Support] Change std::sort to llvm::sort in response to r327219.

Are there instances in llvm where we perform range-based sorting? I see that std has an experimental range-based sort (std::experimental::ranges::sort) which I don't see being used in llvm.

Apr 9 2018, 11:14 AM

Apr 6 2018

jordan_rose accepted D45003: [Support] Make line-number cache robust against access patterns..

Ah, yes, Graydon's convinced me that the change will work and will not regress memory usage terribly, and the new tests look good.

Apr 6 2018, 9:52 AM

Apr 2 2018

jordan_rose added a comment to D45140: [Support] Change std::sort to llvm::sort in response to r327219.

I'm a little disappointed that llvm::sort got added without providing a range-based variant, the way we did for llvm::none_of and llvm::find and others. (I wasn't watching the original thread.) I see no problem with these changes, though!

Apr 2 2018, 9:49 AM

Mar 30 2018

jordan_rose added a comment to D45003: [Support] Make line-number cache robust against access patterns..

That seems about as clever as possible—anything more and it would definitely be overboard. Can you add tests with 255-, 256-, and 257-byte buffers, then? With and without newlines as the last character, and testing the just-past-the-end pointer in addition to something in-bounds?

Mar 30 2018, 9:58 AM

Mar 29 2018

jordan_rose added a comment to D45003: [Support] Make line-number cache robust against access patterns..

And those that do, assume a file is (say) 1000 lines long, it'll cost 8kb to index. Even if we indexed a thousand such files -- a diagnostic in every file of a large project! -- we'd only be talking 8mb.

Mar 29 2018, 10:03 AM
jordan_rose added a comment to D45019: [ADT] NFC: Fix bogus StringSwitch rule-of-five boilerplate.

That's a source compatibility break, but not one that's likely to matter in practice. LGTM.

Mar 29 2018, 9:46 AM

Mar 28 2018

jordan_rose added a comment to D45003: [Support] Make line-number cache robust against access patterns..

That's potentially a lot more memory usage, since the various vectors never get freed. Have you measured what the effect on memory usage is on a large Swift project with diagnostics in many files?

Mar 28 2018, 4:18 PM

Mar 22 2018

jordan_rose closed D44498: Sink PrettyDeclStackTrace down to the AST library.

Committed in rL328276.

Mar 22 2018, 5:10 PM

Mar 14 2018

jordan_rose created D44498: Sink PrettyDeclStackTrace down to the AST library.
Mar 14 2018, 3:30 PM

Mar 9 2018

jordan_rose created D44317: Delete the copy constructor for llvm::yaml::Node.
Mar 9 2018, 10:31 AM

Mar 1 2018

jordan_rose added a comment to D43162: [Parser] (C++) Make -Wextra-semi slightly more useful.

It's been a long time since that commit, but I think the difference is that -pedantic / Extension-type diagnostics are magic and -Wc++98-compat-pedantic is not. I like Richard's way better and if it could be applied to -Wnewline-eof later as well then that sounds great.

Mar 1 2018, 10:30 AM · Restricted Project

Feb 26 2018

jordan_rose accepted D43436: [Perf] Simplify llvm::StringSwitch and improve incremental rebuild by 54%.

Go for it!

Feb 26 2018, 10:16 AM

Feb 20 2018

jordan_rose added inline comments to D43436: [Perf] Simplify llvm::StringSwitch and improve incremental rebuild by 54%.
Feb 20 2018, 10:35 AM

Feb 19 2018

jordan_rose added inline comments to D43436: [Perf] Simplify llvm::StringSwitch and improve incremental rebuild by 54%.
Feb 19 2018, 9:51 AM
jordan_rose added inline comments to D43436: [Perf] Simplify llvm::StringSwitch and improve incremental rebuild by 54%.
Feb 19 2018, 8:29 AM

Nov 27 2017

jordan_rose edited reviewers for D40463: [analyzer] Fix false negative on post-increment of uninitialized variable., added: NoQ; removed: dergachev.a.
Nov 27 2017, 10:17 AM · Restricted Project
jordan_rose edited reviewers for D40463: [analyzer] Fix false negative on post-increment of uninitialized variable., added: dergachev.a; removed: krememek, jordan_rose.
Nov 27 2017, 10:16 AM · Restricted Project

Oct 23 2017

jordan_rose closed D39035: Unnamed bitfields don't block constant evaluation of constexpr constructors.

Landed in rL316408.

Oct 23 2017, 7:25 PM · Restricted Project

Oct 20 2017

jordan_rose added a comment to D39035: Unnamed bitfields don't block constant evaluation of constexpr constructors.

Thanks, Aaron!

Oct 20 2017, 10:42 AM · Restricted Project

Oct 17 2017

jordan_rose created D39035: Unnamed bitfields don't block constant evaluation of constexpr constructors.
Oct 17 2017, 8:03 PM · Restricted Project

Oct 13 2017

jordan_rose closed D38207: lit.py: Add new %{shared_output(LABEL)} substitution.

Committed in rL315697.

Oct 13 2017, 9:12 AM

Oct 12 2017

jordan_rose added a comment to D38865: Add DK_Remark to SMDiagnostic.

Seems reasonable to me. I don't know anything about the MIR parser's use of diagnostics, though.

Oct 12 2017, 4:50 PM

Oct 11 2017

jordan_rose created D38833: BitstreamWriter: Better assertion when a block's abbrev code size is too small.
Oct 11 2017, 5:34 PM

Sep 27 2017

jordan_rose accepted D38327: [Sema] Put nullability fix-it after the end of the pointer..

Nice catch, Volodymyr! Looks good to me.

Sep 27 2017, 12:37 PM

Sep 25 2017

jordan_rose updated the diff for D38207: lit.py: Add new %{shared_output(LABEL)} substitution.

Remove debugging prints.

Sep 25 2017, 5:02 AM
jordan_rose abandoned D38010: lit.py: Allow configs and local configs to have a setup_script entry.

@ddunbar convinced me in person that this is either overkill or doesn't go far enough: as long as there's a shared directory, either there can just be a common setup task at the start of each test that does its own ad hoc filesystem-based synchronization, or we might as well go all the way to full-on inter-test dependencies. I'm going to split out the shared directory stuff into a separate patch and go play with the idea of dependencies for a bit.

Sep 25 2017, 5:02 AM
jordan_rose created D38207: lit.py: Add new %{shared_output(LABEL)} substitution.
Sep 25 2017, 5:02 AM

Sep 19 2017

jordan_rose updated the diff for D38010: lit.py: Allow configs and local configs to have a setup_script entry.

Move setup code from execute_tests_in_pool to execute_tests.

Sep 19 2017, 5:33 PM
jordan_rose added a comment to D38010: lit.py: Allow configs and local configs to have a setup_script entry.

Yep, that's not bad either. I'm not super happy with the idea of lit.local.cfg parsing relying on running in the same process as lit itself, but maybe that ship has sailed.

Sep 19 2017, 4:46 PM
jordan_rose added a comment to D38010: lit.py: Allow configs and local configs to have a setup_script entry.

Oh, no, I definitely need an arbitrarily complex script. Swift wants to prebuild mock libraries shared by several test cases. Today we're either doing it once per test case or using a terrible hack mode that can parse source on the fly.

Sep 19 2017, 4:12 PM
jordan_rose added a comment to D38010: lit.py: Allow configs and local configs to have a setup_script entry.

You mentioned you want to make this work with the multiprocessing pool. That worries me a little bit because different processes are going to be using the same shared output dir (which isn't created up front by the infrastructure), if I understand correctly. Like if you have A and A/B and A/C, then we will run the setup script 3 times in parallel all using the same shared output folder. Is this going to be a source of flakiness?

Sep 19 2017, 3:49 PM
jordan_rose added a comment to D37756: [lit] Force site configs to be run before source-tree configs.

Previously I was just able to do this:

Sep 19 2017, 3:45 PM
jordan_rose updated the diff for D38010: lit.py: Allow configs and local configs to have a setup_script entry.

Make setup_script refer to a Python script rather than an arbitrary executable, as suggested by @zturner.

Sep 19 2017, 3:29 PM
jordan_rose added a comment to D37756: [lit] Force site configs to be run before source-tree configs.

I'm unhappy that I can't run lit's own tests without having to configure, though. That seems like a regression.

Sep 19 2017, 3:12 PM
jordan_rose added inline comments to D38010: lit.py: Allow configs and local configs to have a setup_script entry.
Sep 19 2017, 11:48 AM
jordan_rose added inline comments to D38010: lit.py: Allow configs and local configs to have a setup_script entry.
Sep 19 2017, 11:34 AM
jordan_rose added a comment to D38010: lit.py: Allow configs and local configs to have a setup_script entry.

Actually, I guess I'm a bit confused. What is this solving that you can't already do in a local config? Couldn't you just embed the stuff you want to execute in the local config?

Sep 19 2017, 11:33 AM

Sep 18 2017

jordan_rose added a reviewer for D37756: [lit] Force site configs to be run before source-tree configs: ddunbar.
  • Run lit.py from the source tree against a directory in the build tree.

    Not aware of anyone who does this, but in theory it should work.
Sep 18 2017, 8:11 PM
jordan_rose created D38010: lit.py: Allow configs and local configs to have a setup_script entry.
Sep 18 2017, 5:01 PM

Jul 19 2017

jordan_rose updated subscribers of D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

The addition of "${path}/.git/HEAD" at line 37 is used only once when repo is initially synced "for the first time". This is because ${git_path}/logs/HEAD file at line 34 for Git or Git submodule does not exist with initial repo sync[.]

Jul 19 2017, 9:37 AM

Jul 18 2017

jordan_rose added a comment to D35138: [cmake] Remove deprecated GetSVN.cmake parameters.

Rather than delete these outright, it's probably polite to error on the presence of FIRST_SOURCE_DIR. There might be other out-of-tree projects that need to update.

Jul 18 2017, 2:41 PM
jordan_rose added a comment to D35132: [cmake] GetSVN.cmake takes a list of arguments.

It looks fine to me too. Ideally @beanz would be around to weigh in but it's not such a big change. I think it's okay to land.

Jul 18 2017, 2:41 PM
jordan_rose added a comment to D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

As commented at D34955#798369, this isn't sufficient because it doesn't force a rebuild when new changes are merged in from upstream. It's not harmful to stick with the old version information, but if you can find something better that would be, um, better.

Jul 18 2017, 10:26 AM

Jul 17 2017

jordan_rose accepted D34955: [Basic] Detect Git submodule version in CMake.

Whoops, yes, this new version looks good!

Jul 17 2017, 10:31 AM

Jul 10 2017

jordan_rose added inline comments to D34955: [Basic] Detect Git submodule version in CMake.
Jul 10 2017, 2:17 PM
jordan_rose edited reviewers for D35186: [analyzer] Add annotation for functions taking user-facing strings, added: dcoughlin; removed: jordan_rose.
Jul 10 2017, 10:15 AM

Jul 5 2017

jordan_rose added a comment to D34955: [Basic] Detect Git submodule version in CMake.

I'm not sure why we would care if a commit is made on a branch. The important information here is what commit is checked out, and that's what HEAD refers to.

Jul 5 2017, 1:42 PM

Jul 3 2017

jordan_rose requested changes to D34955: [Basic] Detect Git submodule version in CMake.

If I'm remembering correctly from when I set this up, this isn't just about detecting which version control system you're using; it's about finding a file that will change on every commit. Otherwise, the generated Version.cpp won't be rebuilt after you update.

Jul 3 2017, 9:20 AM

Apr 10 2017

jordan_rose resigned from D31861: [Lexicon] Add BDCE.
Apr 10 2017, 11:07 AM

Mar 28 2017

jordan_rose added a comment to D26108: Add -Wnullability-completeness-on-arrays..

Yep, that's the correct syntax. It's not wonderful, but it's already where the C standard lets you put const, so we're just following established practice. (Learn something new and awful about C every day!)

Mar 28 2017, 10:39 AM
jordan_rose added a comment to D26108: Add -Wnullability-completeness-on-arrays..

No, the arrays themselves need to be marked as nullable or non-nullable. Remember that in C array parameters are passed as pointers.

Mar 28 2017, 10:33 AM

Mar 27 2017

jordan_rose updated subscribers of D31372: Support Microsoft mangling of swift calling convention methods.
Mar 27 2017, 9:54 AM
jordan_rose edited reviewers for D31372: Support Microsoft mangling of swift calling convention methods, added: rjmccall, aschwaighofer; removed: jordan_rose.
Mar 27 2017, 9:54 AM

Mar 22 2017

jordan_rose added a comment to D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type .

This looks like it's only coming up for declarations. What about assignments?

Mar 22 2017, 6:14 PM

Mar 15 2017

jordan_rose added inline comments to D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.
Mar 15 2017, 5:05 PM
jordan_rose added a reviewer for D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak: rjmccall.

The warning-related parts look reasonable to me.

Mar 15 2017, 3:42 PM

Mar 10 2017

jordan_rose closed D30855: [unittest] Explicitly specify alignment when using BumpPtrAllocator..

Committed in rL297540.

Mar 10 2017, 5:37 PM
jordan_rose edited reviewers for D30855: [unittest] Explicitly specify alignment when using BumpPtrAllocator., added: bogner; removed: dexonsmith.
Mar 10 2017, 5:04 PM
jordan_rose created D30855: [unittest] Explicitly specify alignment when using BumpPtrAllocator..
Mar 10 2017, 5:03 PM

Mar 8 2017

jordan_rose closed D30723: Add red zones to BumpPtrAllocator under ASan.

Committed in rL297310.

Mar 8 2017, 2:05 PM
jordan_rose added a comment to D30723: Add red zones to BumpPtrAllocator under ASan.

Thanks, Pete! Will land soon, then.

Mar 8 2017, 11:42 AM

Mar 7 2017

jordan_rose created D30723: Add red zones to BumpPtrAllocator under ASan.
Mar 7 2017, 3:50 PM

Feb 28 2017

jordan_rose accepted D30482: [Analyzer] Fix crash in ObjCPropertyChecker on protocol property.

Looks good to me. Good catch.

Feb 28 2017, 5:17 PM

Feb 7 2017

jordan_rose edited reviewers for D29181: Make TrailingObjects private inheritance of TrailingObjectsImpl protected, added: jyknight, rsmith; removed: llvm-commits.
Feb 7 2017, 7:26 PM

Jan 24 2017

jordan_rose added inline comments to D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type .
Jan 24 2017, 4:39 PM

Jan 19 2017

jordan_rose closed D28924: [AST Printer] Print attributes on enum constants.

Landed as-is in rL292571.

Jan 19 2017, 7:45 PM
jordan_rose added a comment to D28924: [AST Printer] Print attributes on enum constants.

Interestingly, this case doesn't actually work yet; we unconditionally print enum attributes after the close-brace even though that's not valid for C++ attributes. Do you think I should change that as well, or just land this patch as is?

Jan 19 2017, 5:25 PM
jordan_rose added a comment to D28924: [AST Printer] Print attributes on enum constants.

Good idea, will do.

Jan 19 2017, 4:15 PM
jordan_rose created D28924: [AST Printer] Print attributes on enum constants.
Jan 19 2017, 4:01 PM

Dec 19 2016

jordan_rose closed D27837: Add fix-it notes to the nullability consistency warning.
Dec 19 2016, 1:12 PM
jordan_rose accepted D27837: Add fix-it notes to the nullability consistency warning.

Doug was okay with the idea and I trust Alex and Akira would have caught any major problems. Committed in r290132.

Dec 19 2016, 1:12 PM

Dec 16 2016

jordan_rose updated the diff for D27837: Add fix-it notes to the nullability consistency warning.

Updated names to match LLVM style.

Dec 16 2016, 2:26 PM
jordan_rose added inline comments to D27837: Add fix-it notes to the nullability consistency warning.
Dec 16 2016, 8:53 AM

Dec 15 2016

jordan_rose retitled D27837: Add fix-it notes to the nullability consistency warning from to Add fix-it notes to the nullability consistency warning.
Dec 15 2016, 6:02 PM

Nov 14 2016

jordan_rose added a comment to D26568: [ADT] Delete Twine constructors which accept StringRef rvalues (NFC).

I'm inclined to agree with @dblaikie's email comment: assigning a Twine is pretty much never safe anyway, so we should just delete operator= altogether. (I'd love to get rid of the copy-constructor too and just allow moves, but I think it still makes sense to copy-construct when combining a Twine argument with multiple different suffixes.)

Nov 14 2016, 11:15 AM

Nov 10 2016

jordan_rose added a comment to D26227: Don't require nullability on 'va_list'..

One more fix-up in rL286542. Hopefully the last one.

Nov 10 2016, 5:39 PM
jordan_rose closed D26227: Don't require nullability on 'va_list'..

Committed in rL286522, with a fix-up to make the check for va_lists more conservative in rL286531.

Nov 10 2016, 4:50 PM
jordan_rose closed D26109: Warn when 'assume_nonnull' infers nullability within an array..

Committed as rL286521.

Nov 10 2016, 4:49 PM
jordan_rose closed D26108: Add -Wnullability-completeness-on-arrays..

Committed as rL286520, with a slight fix-up for MSVC in rL286525.

Nov 10 2016, 4:49 PM
jordan_rose closed D25850: Accept nullability annotations (_Nullable) on array parameters.

Committed as rL286519.

Nov 10 2016, 4:48 PM

Nov 9 2016

jordan_rose added inline comments to D26108: Add -Wnullability-completeness-on-arrays..
Nov 9 2016, 5:21 PM
jordan_rose added a comment to D26108: Add -Wnullability-completeness-on-arrays..

Ah, my apologies, @ahatanak. I was testing against the Swift branch of Clang.

Nov 9 2016, 4:50 PM

Nov 8 2016

jordan_rose added a dependent revision for D26108: Add -Wnullability-completeness-on-arrays.: D26109: Warn when 'assume_nonnull' infers nullability within an array..
Nov 8 2016, 6:10 PM
jordan_rose added a dependency for D26109: Warn when 'assume_nonnull' infers nullability within an array.: D26108: Add -Wnullability-completeness-on-arrays..

Depends on D26108 too, for the tests to apply cleanly.

Nov 8 2016, 6:10 PM
jordan_rose added a dependent revision for D26108: Add -Wnullability-completeness-on-arrays.: D26227: Don't require nullability on 'va_list'..
Nov 8 2016, 6:10 PM