This is an archive of the discontinued LLVM Phabricator instance.

Differential D64019

[clangd] Turn background-index on by default
ClosedPublic

Authored by kadircet on Jul 1 2019, 9:15 AM.

Details

Reviewers
sammccall
Commits
rGc6fdefa0ee81: [clangd] Turn background-index on by default
rCTE365124: [clangd] Turn background-index on by default
rL365124: [clangd] Turn background-index on by default

Diff Detail

Repository
rL LLVM

Event Timeline

kadircet created this revision.Jul 1 2019, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 9:15 AM
Herald added subscribers: cfe-commits, arphaman, jkorous and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B34136: Diff 207346.Jul 1 2019, 9:15 AM
sammccall accepted this revision.Jul 2 2019, 12:38 AM

Great! please land once D64018 is done.

This revision is now accepted and ready to land.Jul 2 2019, 12:38 AM
kadircet added parent revisions: D63986: [clangd] Also cache failures while indexing, D64018: [clangd] Store hash of command line in index shards..Jul 2 2019, 12:44 AM
hokein added a subscriber: hokein.Jul 2 2019, 1:57 AM
hokein added inline comments.
clang-tools-extra/clangd/tool/ClangdMain.cpp
191 ↗(On Diff #207346)

should we remove the experimental term here?

kadircet marked an inline comment as done.Jul 4 2019, 1:57 AM
kadircet added inline comments.
clang-tools-extra/clangd/tool/ClangdMain.cpp
191 ↗(On Diff #207346)

i would rather do that if we are happy with the feedbacks(or no feedbacks) within the following weeks

Closed by commit rL365124: [clangd] Turn background-index on by default (authored by kadircet). · Explain WhyJul 4 2019, 2:58 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2019, 2:58 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kadircet mentioned this in D66943: [clangd][NFC] Update background-index command line description.Aug 29 2019, 7:04 AM
kadircet mentioned this in rL370367: [clangd][NFC] Update background-index command line description.Aug 29 2019, 7:40 AM
kadircet mentioned this in rG1c4cd4960840: [clangd][NFC] Update background-index command line description.
hans mentioned this in rL370370: Merging r370367:.Aug 29 2019, 7:53 AM
hansw mentioned this in rG16d2d313fa34: Merging r370367: --------------------------------------------------------------….Aug 29 2019, 7:53 AM

Revision Contents

PathSize
clang-tools-extra/
trunk/
clangd/
tool/
2 lines

Diff 208007

clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp

Show First 20 Lines • Show All 183 Lines • ▼ Show 20 Lines llvm::cl::desc(
"eventually. Don't rely on it"), "eventually. Don't rely on it"),
llvm::cl::init(""), llvm::cl::Hidden); llvm::cl::init(""), llvm::cl::Hidden);
static llvm::cl::opt<bool> EnableBackgroundIndex( static llvm::cl::opt<bool> EnableBackgroundIndex(
"background-index", "background-index",
llvm::cl::desc( llvm::cl::desc(
"Index project code in the background and persist index on disk. " "Index project code in the background and persist index on disk. "
"Experimental"), "Experimental"),
llvm::cl::init(false), llvm::cl::Hidden); llvm::cl::init(true));
static llvm::cl::opt<int> BackgroundIndexRebuildPeriod( static llvm::cl::opt<int> BackgroundIndexRebuildPeriod(
"background-index-rebuild-period", "background-index-rebuild-period",
llvm::cl::desc( llvm::cl::desc(
"If set to non-zero, the background index rebuilds the symbol index " "If set to non-zero, the background index rebuilds the symbol index "
"periodically every X milliseconds; otherwise, the " "periodically every X milliseconds; otherwise, the "
"symbol index will be updated for each indexed file"), "symbol index will be updated for each indexed file"),
llvm::cl::init(5000), llvm::cl::Hidden); llvm::cl::init(5000), llvm::cl::Hidden);
▲ Show 20 Lines • Show All 357 Lines • Show Last 20 Lines