This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objdump] Update the doc for --disassemble-functions.
ClosedPublic

Authored by ychen on Jun 25 2019, 1:31 PM.

Details

Summary

Update the doc after llvm-svn: 364121 is landed.
With two more trivial fixes that are not related to
--disassemble-functions but still about llvm-objdump.

Diff Detail

Repository
rL LLVM

Event Timeline

ychen created this revision.Jun 25 2019, 1:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2019, 1:31 PM
MaskRay accepted this revision.Jun 25 2019, 7:45 PM
This revision is now accepted and ready to land.Jun 25 2019, 7:45 PM
jhenderson accepted this revision.Jun 26 2019, 2:09 AM

LGTM, with one suggestion.

llvm/docs/CommandGuide/llvm-objdump.rst
38 ↗(On Diff #206521)

Perhaps worth changing "demangled symbols" to "demangled symbol names" and "mangled symbols" to "mangled symbol names".

ychen updated this revision to Diff 206699.Jun 26 2019, 9:26 AM
  • update
ychen marked an inline comment as done.Jun 26 2019, 9:26 AM
jhenderson accepted this revision.Jun 27 2019, 1:38 AM
This revision was automatically updated to reflect the committed changes.