This is an archive of the discontinued LLVM Phabricator instance.

[LLVM-C] Add LLVM-C.dll to Windows installer package
ClosedPublic

Authored by Wallbraker on Jun 24 2019, 7:44 AM.

Details

Summary

This is a follow up to D56781, D56774 and D35077 to makes the LLVM-C.dll file and LLVM-C.lib be installed on Windows, just like LTO.dll and LTO.lib are.

Diff Detail

Repository
rL LLVM

Event Timeline

Wallbraker created this revision.Jun 24 2019, 7:44 AM
Wallbraker edited the summary of this revision. (Show Details)Jun 24 2019, 7:48 AM
hans accepted this revision.Jun 24 2019, 7:50 AM

It's hard to argue llvm-c.dll is part of the toolchain though :-/

This revision is now accepted and ready to land.Jun 24 2019, 7:50 AM
Wallbraker added a comment.EditedJun 24 2019, 1:03 PM

Thanks for the review!

I'm pretty sure libclang.[lib|dll] is only installed and not used by any of the shipped binaries so not really part of the toolchain either. Not sure about LTO.[lib|dll] tho. I would be happy if LLVM-C and libclang was offered as a separate download.

PS: I do not have commit rights so would be very grateful if somebody could commit this for me.

hans added a comment.Jun 25 2019, 12:06 AM

Thanks for the review!

I'm pretty sure libclang.[lib|dll] is only installed and not used by any of the shipped binaries so not really part of the toolchain either. Not sure about LTO.[lib|dll] tho. I would be happy if LLVM-C and libclang was offered as a separate download.

Yeah, it's not very consistent :-)

PS: I do not have commit rights so would be very grateful if somebody could commit this for me.

Committed in r364275.

This revision was automatically updated to reflect the committed changes.