Page MenuHomePhabricator

[llvm-mca][docs] clarify how the quality of the perf report is affected by the quality of the scheduling models.
ClosedPublic

Authored by andreadb on Jun 19 2019, 8:02 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

andreadb created this revision.Jun 19 2019, 8:02 AM

Forgot to add llvm-commits to the subscribers. Apologies for the spam.

lebedev.ri accepted this revision.Jun 19 2019, 8:24 AM

Makes sense to me at least. Should this be cross-referenced somewhere else?

This revision is now accepted and ready to land.Jun 19 2019, 8:24 AM
mattd added inline comments.Jun 19 2019, 8:36 AM
docs/CommandGuide/llvm-mca.rst
46 ↗(On Diff #205591)

This reads nicely, but I suggest adding "scheduling" to be clearer about what models. "[...] is inevitably affected by the quality of the scheduling models in LLVM."

mattd accepted this revision.Jun 19 2019, 8:36 AM
andreadb marked 2 inline comments as done.Jun 19 2019, 8:56 AM

Thanks for the reviews @lebedev.ri and @mattd

Makes sense to me at least. Should this be cross-referenced somewhere else?

My opinion is that this doesn't need to be cross-referenced.

docs/CommandGuide/llvm-mca.rst
46 ↗(On Diff #205591)

I will change it. Thanks

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2019, 9:08 AM

Makes sense to me at least. Should this be cross-referenced somewhere else?

We'd need https://bugs.llvm.org/show_bug.cgi?id=37516 for that