This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Rename MVE instructions in Tablegen for consistency.

Authored by simon_tatham on Jun 18 2019, 6:36 AM.



Their names began with a mishmash of MVE_, t2 and no prefix at
all. Now they all start with MVE_, which seems like a reasonable
choice on the grounds that (a) NEON is the thing they're most at risk
of being confused with, and (b) MVE implies Thumb-2, so a prefix
indicating MVE is strictly more specific than one indicating Thumb-2.

Diff Detail


Event Timeline

simon_tatham created this revision.Jun 18 2019, 6:36 AM
SjoerdMeijer accepted this revision.Jun 18 2019, 6:50 AM

looks like an excellent idea to me.

This revision is now accepted and ready to land.Jun 18 2019, 6:50 AM

I like the consistency this gives. Especially at immediately identifying MVE vs Neon instructions. What about the couple of places pointed out below?

476 ↗(On Diff #205323)

These six?

575 ↗(On Diff #205323)

These four?

simon_tatham marked 2 inline comments as done.Jun 18 2019, 8:01 AM
This revision was automatically updated to reflect the committed changes.