This is an archive of the discontinued LLVM Phabricator instance.

Differential D63245

clang-scan-deps: Fix -DBUILD_SHARED_LIBS=ON build
ClosedPublic

Authored by sbc100 on Jun 13 2019, 1:33 AM.

Download Raw Diff

Details

Reviewers

Commits

rGf9ad6e57d96b: [clang-scan-deps] Fix -DBUILD_SHARED_LIBS=ON build
rC363238: [clang-scan-deps] Fix -DBUILD_SHARED_LIBS=ON build
rL363238: [clang-scan-deps] Fix -DBUILD_SHARED_LIBS=ON build

Summary

The -DBUILD_SHARED_LIBS=ON build was broken in rL363204

Diff Detail

Repository: rL LLVM

Event Timeline

sbc100 created this revision.Jun 13 2019, 1:33 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2019, 1:33 AM

Herald added subscribers: cfe-commits, tschuett, aheejin, mgorny. · View Herald Transcript

Harbormaster completed remote builds in B33320: Diff 204448.Jun 13 2019, 1:35 AM

sbc100 edited the summary of this revision. (Show Details)Jun 13 2019, 1:45 AM

sbc100 added a reviewer: arphaman.

Herald added a subscriber: dexonsmith. · View Herald TranscriptJun 13 2019, 1:46 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 13 2019, 1:55 AM

Closed by commit rL363238: [clang-scan-deps] Fix -DBUILD_SHARED_LIBS=ON build (authored by sbc). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2019, 1:55 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

Path

Size

cfe/

trunk/

tools/

clang-scan-deps/

1 line

Diff 204452

cfe/trunk/tools/clang-scan-deps/CMakeLists.txt

	Show All 10 Lines		set(CLANG_SCAN_DEPS_LIB_DEPS
	clangAST			clangAST
	clangBasic			clangBasic
	clangCodeGen			clangCodeGen
	clangDriver			clangDriver
	clangFrontend			clangFrontend
	clangFrontendTool			clangFrontendTool
	clangLex			clangLex
	clangParse			clangParse
				clangSerialization
	clangTooling			clangTooling
	)			)

	target_link_libraries(clang-scan-deps			target_link_libraries(clang-scan-deps
	PRIVATE			PRIVATE
	${CLANG_SCAN_DEPS_LIB_DEPS}			${CLANG_SCAN_DEPS_LIB_DEPS}
	)			)