Page MenuHomePhabricator
Differential D62940

[PPC32] Support TLS GD/LE/IE/LE relocation types and their relaxations
ClosedPublic
Actions

Authored by MaskRay on Jun 5 2019, 11:38 PM.

Details

Reviewers
grimar
ruiu
• espindola
Commits
rLLD362722: [PPC32] Support GD/LD/IE/LE TLS models and their relaxations
rG7ccfdad7ab7b: [PPC32] Support GD/LD/IE/LE TLS models and their relaxations
rL362722: [PPC32] Support GD/LD/IE/LE TLS models and their relaxations

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Jun 5 2019, 11:38 PM
Herald added a reviewer: • espindola. · View Herald TranscriptJun 5 2019, 11:38 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, jsji, kbarton and 3 others. · View Herald Transcript
Harbormaster completed remote builds in B32972: Diff 203291.Jun 5 2019, 11:40 PM
MaskRay updated this revision to Diff 203292.Jun 5 2019, 11:50 PM

Forgot to add ppc32-tls-gd.s

ruiu accepted this revision.Jun 5 2019, 11:51 PM

LGTM

ELF/Arch/PPC.cpp
345 ↗(On Diff #203291)

nit: you can remove {}.

361 ↗(On Diff #203291)

ditto

This revision is now accepted and ready to land.Jun 5 2019, 11:51 PM
Harbormaster completed remote builds in B32973: Diff 203292.Jun 5 2019, 11:51 PM
MaskRay added a parent revision: D62464: [PPC32] Improve the 32-bit PowerPC port.Jun 6 2019, 12:32 AM
MaskRay mentioned this in D62464: [PPC32] Improve the 32-bit PowerPC port.Jun 6 2019, 3:36 AM
Closed by commit rL362722: [PPC32] Support GD/LD/IE/LE TLS models and their relaxations (authored by MaskRay). · Explain WhyJun 6 2019, 10:00 AM
This revision was automatically updated to reflect the committed changes.
MaskRay mentioned this in rL362721: [PPC32] Improve the 32-bit PowerPC port.
MaskRay mentioned this in rG82442adfc033: [PPC32] Improve the 32-bit PowerPC port.
plotfi added a subscriber: plotfi.EditedJun 6 2019, 10:54 AM

I am going to upload a fix to these tests. sed "s/# REQUIES: ppc/# REQUIRES: ppc/g"

Our internal bots fail with these.

plotfi added a comment.Jun 6 2019, 11:27 AM

Tests fixed. Everything should be passing now.

ruiu added a comment.Jun 7 2019, 2:49 AM

LGTM

lld/trunk/ELF/Arch/PPC.cpp
56

nit: it may be easier to read if you change this to

if (Config->IsLE)
  return read32(Loc);
else
  return read32(Loc - 2);
60

Ditto

Revision Contents
Changeset List

PathSize
lld/
trunk/
ELF/
Arch/
186 lines
7 lines
1 line
1 line
test/
ELF/
98 lines
67 lines
82 lines
24 lines

Diff 203393

View Options

lld/trunk/ELF/Arch/PPC.cpp

Loading...
View Options

lld/trunk/ELF/Arch/PPC64.cpp

Loading...
View Options

lld/trunk/ELF/InputSection.cpp

Loading...
View Options

lld/trunk/ELF/Target.h

Loading...
View Options

lld/trunk/test/ELF/ppc32-tls-gd.s

Loading...
View Options

lld/trunk/test/ELF/ppc32-tls-ie.s

Loading...
View Options

lld/trunk/test/ELF/ppc32-tls-ld.s

Loading...
View Options

lld/trunk/test/ELF/ppc32-tls-le.s

Loading...