I'm not familiar with this pass, so a thorough review is appreciated.
Note that I was not able to find existing tests for the binary FP operators. It seems as if they're just pass-throughs since they don't touch memory. Or did I miss something?
Differential D62909
[MSAN] Add unary FNeg visitor to the MemorySanitizer cameron.mcinally on Jun 5 2019, 8:15 AM. Authored by
Details I'm not familiar with this pass, so a thorough review is appreciated. Note that I was not able to find existing tests for the binary FP operators. It seems as if they're just pass-throughs since they don't touch memory. Or did I miss something?
Diff Detail Event TimelineComment Actions The instrumentation pass change looks good. |