This is an archive of the discontinued LLVM Phabricator instance.

[MSAN] Add unary FNeg visitor to the MemorySanitizer
ClosedPublic

Authored by cameron.mcinally on Jun 5 2019, 8:15 AM.

Details

Summary

I'm not familiar with this pass, so a thorough review is appreciated.

Note that I was not able to find existing tests for the binary FP operators. It seems as if they're just pass-throughs since they don't touch memory. Or did I miss something?

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2019, 8:15 AM

The instrumentation pass change looks good.
There is a test for fdiv in msan_basic.ll, you can do something similar.

Thanks, @eugenis. Not sure how I missed that..

eugenis accepted this revision.Jun 5 2019, 2:56 PM

Thanks!
LGTM

This revision is now accepted and ready to land.Jun 5 2019, 2:56 PM
This revision was automatically updated to reflect the committed changes.