This is an archive of the discontinued LLVM Phabricator instance.

Differential D62817

[test][llvm-objcopy] Test llvm-objcopy with standard streams
ClosedPublic

Authored by abrachet on Jun 3 2019, 9:55 AM.

Details

Reviewers
jhenderson
rupprecht
• espindola
alexander-shaposhnikov
jakehehrlich
Commits
rG375d5fb9ca22: [test][llvm-objcopy] Test llvm-objcopy with standard streams
rL362556: [test][llvm-objcopy] Test llvm-objcopy with standard streams
Summary

Ensure that redirecting input to stdin is no different than a normal file. Likewise outputting to stdout should be no different than outputting to a file.

Diff Detail

Event Timeline

abrachet created this revision.Jun 3 2019, 9:55 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJun 3 2019, 9:55 AM
Herald added a reviewer: alexander-shaposhnikov. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, MaskRay, arichardson, emaste. · View Herald Transcript
alexander-shaposhnikov added inline comments.Jun 3 2019, 3:28 PM
llvm/test/tools/llvm-objcopy/ELF/standard-streams.test
3

cmp ? and the same below
(for consistency)
(if I'm not mistaken all the existing tests use cmp to verify that two binary files are identical)

abrachet updated this revision to Diff 202846.Jun 3 2019, 7:59 PM

Now using cmp rather than diff

abrachet updated this revision to Diff 202866.Jun 4 2019, 12:22 AM

Put test case in ELF/ directory

abrachet marked an inline comment as done.Jun 4 2019, 12:23 AM
jakehehrlich accepted this revision.Jun 4 2019, 12:29 AM

Neat! I didn't even know this was possible TBH

llvm/test/tools/llvm-objcopy/ELF/standard-streams.test
2

Instead of using cat you can just redirect the file in.

This revision is now accepted and ready to land.Jun 4 2019, 12:29 AM
abrachet updated this revision to Diff 202867.Jun 4 2019, 12:45 AM

Directed a file in instead of piping cat

abrachet marked an inline comment as done.Jun 4 2019, 12:45 AM
alexander-shaposhnikov accepted this revision.Jun 4 2019, 1:10 AM
jhenderson accepted this revision.Jun 4 2019, 4:01 AM

LGTM, with one nit.

llvm/test/tools/llvm-objcopy/ELF/standard-streams.test
8

Delete this blank line. There should be a single trailing new line character at the end of the last line in the file with content, but nothing after that.

rupprecht accepted this revision.Jun 4 2019, 3:10 PM
Closed by commit rL362556: [test][llvm-objcopy] Test llvm-objcopy with standard streams (authored by abrachet). · Explain WhyJun 4 2019, 3:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
ELF/
7 lines

Diff 202743

llvm/test/tools/llvm-objcopy/ELF/standard-streams.test

  • This file was added.
# RUN: cat %p/Inputs/alloc-symtab.o | llvm-objcopy - %t
# RUN: llvm-objcopy %p/Inputs/alloc-symtab.o %t1
jakehehrlichUnsubmitted
Done
ReplyInline Actions

Instead of using cat you can just redirect the file in.

jakehehrlich: Instead of using cat you can just redirect the file in.
# RUN: diff %t %t1
alexander-shaposhnikovUnsubmitted
Done
ReplyInline Actions

cmp ? and the same below
(for consistency)
(if I'm not mistaken all the existing tests use cmp to verify that two binary files are identical)

alexander-shaposhnikov: cmp ? and the same below (for consistency) (if I'm not mistaken all the existing tests use cmp…
# RUN: llvm-objcopy %p/Inputs/alloc-symtab.o - > %t2
# RUN: diff %t1 %t2
jhendersonUnsubmitted
Not Done
ReplyInline Actions

Delete this blank line. There should be a single trailing new line character at the end of the last line in the file with content, but nothing after that.

jhenderson: Delete this blank line. There should be a single trailing new line character at the end of the…