[LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

[kusmour]

Summary

llvm updated the function from llvm::codeview::getRegisterNames() to llvm::codeview::getRegisterNames(CPUType)
according to the function implementation, there are only two different register number list: ARM64 for ARM64, X64 for all others
the backends for arm64 and aarch64 are merged so from lldb side, aarch64 will have llvm::codeview::CPUType::ARM64
and others will set CPUType to llvm::codeview::CPUType::X64 for now

[xiaobai]

lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp

32

break here

[kusmour]

fix switch statement

[kusmour]

lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp

32

omg thx

[mgorny]

As I said on the other patch, I don't believe this belongs in LLDB. Otherwise, you require every user of codeview to maintain and update an accurate mapping of targets currently supported by llvm::codeview. Instead, this should be part of codeview API.

[compnerd]

Generally, clang-format the changes, it will catch the formatting things.

lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp

28

Space after the switch.

35

Please add a break after this.

[kusmour]

D62772 toke care of this

lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp

 using namespace lldb_private::postfix;
 
 static uint32_t ResolveLLDBRegisterNum(llvm::StringRef reg_name, llvm::Triple::ArchType arch_type) {
+  llvm::codeview::CPUType cpu;
+  switch(arch_type) {
+    case llvm::Triple::ArchType::aarch64:
+    case llvm::Triple::ArchType::aarch64_be:
+    case llvm::Triple::ArchType::aarch64_32:
+      cpu = llvm::codeview::CPUType::ARM64;
+    default:
+      cpu = llvm::codeview::CPUType::X64;
+  }
   // lookup register name to get lldb register number
   llvm::ArrayRef<llvm::EnumEntry<uint16_t>> register_names =
-      llvm::codeview::getRegisterNames();
+      llvm::codeview::getRegisterNames(cpu);
   auto it = llvm::find_if(
       register_names,
       [&reg_name](const llvm::EnumEntry<uint16_t> &register_entry) {