Page MenuHomePhabricator

[libcxx] Use libtool when merging archives on Apple platforms
ClosedPublic

Authored by phosek on May 31 2019, 11:33 PM.

Details

Summary

ar doesn't produce correct results when used for linking static
archives on Apple platforms, so instead use libtool -static which is
the official way to build static archives on those platforms.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.May 31 2019, 11:33 PM
mcgrathr accepted this revision.May 31 2019, 11:35 PM
mcgrathr added a subscriber: mcgrathr.

lgtm

This revision is now accepted and ready to land.May 31 2019, 11:35 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2019, 6:14 PM

This looks fine to me, but I'd like @ldionne to weigh in on this.