Page MenuHomePhabricator

Write new tests for r362121
ClosedPublic

Authored by mtrent on May 30 2019, 11:53 AM.

Details

Summary

The tests for r362121 ran dsymutil against a test binary every time.
This caused problems on lld-x86_64-ubuntu-fast as dsymutil required
a lipo tool be available to process those binaries.

This change rewrites the new test cases in macho-disassemble-g-dsym
to use bespoke test binaries (exe and dwarf) simplifying the test's
runtime dependencies.

The changes to tools/llvm-objdump/MachODump.cpp are unchanged from
r362121

Diff Detail

Repository
rL LLVM

Event Timeline

mtrent created this revision.May 30 2019, 11:53 AM
Herald added a project: Restricted Project. · View Herald Transcript
pete accepted this revision.May 30 2019, 12:01 PM

I'm trusting the binary blobs are good. Phab doesn't have a built in mach-o parser :)

This revision is now accepted and ready to land.May 30 2019, 12:01 PM

We're actively working on llvm-lipo (we have a bunch more diffs in the pipeline that'll be coming through over the summer). Is it worth adding either a TODO or filing a bug to change these tests once llvm-lipo is complete enough to support the required functionality?

This revision was automatically updated to reflect the committed changes.