Page MenuHomePhabricator

[CodeComplete] Add a bit more whitespace to completed patterns
ClosedPublic

Authored by ilya-biryukov on May 29 2019, 11:47 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

ilya-biryukov created this revision.May 29 2019, 11:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2019, 11:47 AM
gribozavr accepted this revision.May 29 2019, 5:16 PM

I totally agree about the space before the opening curly, but the space before the opening paren is a matter of style. Certainly it does match LLVM style better, but it does not match some other styles.

I guess there's no way to satisfy everyone without an automatic reformatter, and if we were to pick a "default" style it might as well be LLVM, so I approve.

This revision is now accepted and ready to land.May 29 2019, 5:16 PM

I totally agree about the space before the opening curly, but the space before the opening paren is a matter of style. Certainly it does match LLVM style better, but it does not match some other styles.

I guess there's no way to satisfy everyone without an automatic reformatter, and if we were to pick a "default" style it might as well be LLVM, so I approve.

Totally agree. I was also torn on this, but since there's no reasonable way to get the formatting options on code completion now, matching the LLVM style looks like the best trade-off.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2019, 1:32 AM