Page MenuHomePhabricator

[NFC] Check the endianness after the CodeGenPrepare

Authored by steven.zhang on May 24 2019, 1:14 AM.



This test case was added by to check the endianness to make sure that, splitMergedValStore works as expected. And it checks the endianness basing on the assembly instructions.

The patch in is trying to combine some stores into one with some conditions. And for this case, the splitMergedValStore will split the stores, and the split stores matches the pattern of D61843, which result in the check failed.

Therefore, I commit this NFC patch to do the endianness check after CodeGenPrepare to avoid the interfere from later transformation.

Diff Detail

Event Timeline

steven.zhang created this revision.May 24 2019, 1:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2019, 1:14 AM

Hi @jonpa
As is approved but blocking by this patch, would you please help me review the change ? Thank you !

RKSimon added a subscriber: uweigand.

@uweigand Any comments? @jonpa seems to be away at the moment I think?

uweigand accepted this revision.May 31 2019, 12:10 PM

I agree this still checks the same thing, so the patch LGTM.

This revision is now accepted and ready to land.May 31 2019, 12:10 PM

@steven.zhang I think you've gotten the parent-child the wrong way around for this and D61843 - my request was that this gets committed first and then D61843 is rebased so it shows the diff in codegenprepare-splitstore.ll

I have never used the children-parent before. I just add it as parent revision now, no more action. This is what I want to do:

  1. commit this patch.
  2. rebase the parent revision patch and commit it. (I need to update the patch for that revision in theory)

Do you mean that, phabricator has some method that, I don't need to update the patch for the parent revision ?

steven.zhang closed this revision.Jun 4 2019, 1:43 AM

This was committed at rL362471