This is an archive of the discontinued LLVM Phabricator instance.

Differential D62333

Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests
ClosedPublic

Authored by quantum on May 23 2019, 11:21 AM.

Details

Reviewers
tlively
aheejin
Commits
rGa8e0d49c0ce0: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests
rC361536: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests
rL361536: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests
Summary

Add correct cmake dependencies so that ToolingTests link successfully.

Diff Detail

Repository
rL LLVM

Event Timeline

quantum created this revision.May 23 2019, 11:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2019, 11:21 AM
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B32403: Diff 201022.May 23 2019, 11:21 AM
tlively accepted this revision.May 23 2019, 11:38 AM
This revision is now accepted and ready to land.May 23 2019, 11:38 AM
Closed by commit rL361536: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests (authored by tlively). · Explain WhyMay 23 2019, 11:52 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2019, 11:52 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
thakis added a subscriber: thakis.May 25 2019, 6:06 PM
thakis added inline comments.
cfe/trunk/unittests/Tooling/CMakeLists.txt
4

The library is already up here. Why do we need it twice?

quantum marked 2 inline comments as done.May 28 2019, 10:44 AM
quantum added inline comments.
cfe/trunk/unittests/Tooling/CMakeLists.txt
4

We don't. It's removed in the code that's merged.

pzheng added a subscriber: pzheng.Jun 5 2019, 12:05 PM
pzheng added inline comments.
cfe/trunk/unittests/Tooling/CMakeLists.txt
4

Pushed a patch to remove the duplicate. https://reviews.llvm.org/D62924

Revision Contents

PathSize
cfe/
trunk/
unittests/
Tooling/
1 line

Diff 201036

cfe/trunk/unittests/Tooling/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
Support Support
TestingSupport TestingSupport
thakisUnsubmitted
Not Done
ReplyInline Actions

The library is already up here. Why do we need it twice?

thakis: The library is already up here. Why do we need it twice?
quantumAuthorUnsubmitted
Done
ReplyInline Actions

We don't. It's removed in the code that's merged.

quantum: We don't. It's removed in the code that's merged.
pzhengUnsubmitted
Not Done
ReplyInline Actions

Pushed a patch to remove the duplicate. https://reviews.llvm.org/D62924

pzheng: Pushed a patch to remove the duplicate. https://reviews.llvm.org/D62924
) )
# By default MSVC has a 2^16 limit on the number of sections in an object file, # By default MSVC has a 2^16 limit on the number of sections in an object file,
# and this needs more than that. # and this needs more than that.
if (MSVC) if (MSVC)
set_source_files_properties(RecursiveASTVisitorTest.cpp PROPERTIES COMPILE_FLAGS /bigobj) set_source_files_properties(RecursiveASTVisitorTest.cpp PROPERTIES COMPILE_FLAGS /bigobj)
set_source_files_properties(RecursiveASTVisitorTestExprVisitor.cpp PROPERTIES COMPILE_FLAGS /bigobj) set_source_files_properties(RecursiveASTVisitorTestExprVisitor.cpp PROPERTIES COMPILE_FLAGS /bigobj)
endif() endif()
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Linestarget_link_libraries(ToolingTests
clangFrontend clangFrontend
clangLex clangLex
clangRewrite clangRewrite
clangSerialization clangSerialization
clangTooling clangTooling
clangToolingCore clangToolingCore
clangToolingInclusions clangToolingInclusions
clangToolingRefactor clangToolingRefactor
LLVMTestingSupport
) )
add_subdirectory(Syntax) add_subdirectory(Syntax)