This is an archive of the discontinued LLVM Phabricator instance.

UpdateTestChecks: fix AMDGPU handling
ClosedPublic

Authored by lebedev.ri on May 18 2019, 2:57 AM.

Details

Summary

Was looking into supporting (srl (shl x, c1), c2) with c1 != c2 in dagcombiner,
this test changes, but makes update_llc_test_checks.py unhappy.

Many AMDGPU tests specify -march, not -mtriple, which results in update_llc_test_checks.py
defaulting to x86 asm function detection heuristics, which don't work here.
I propose to fix this by adding an infrastructure to map from -march to -mtriple,
in the UpdateTestChecks tooling.

Diff Detail

Repository
rL LLVM

Event Timeline

lebedev.ri created this revision.May 18 2019, 2:57 AM
arsenm accepted this revision.May 18 2019, 5:13 AM
arsenm added inline comments.
utils/UpdateTestChecks/asm.py
205

Why this hardcoded list?

This revision is now accepted and ready to land.May 18 2019, 5:13 AM
lebedev.ri marked an inline comment as done.May 18 2019, 5:47 AM
lebedev.ri added inline comments.
utils/UpdateTestChecks/asm.py
205

I'm not sure how to answer that.
Because this is the pattern that will allow to most easily add new entries, should that be needed.
I'm not sure how else to acquire this mapping.

This revision was automatically updated to reflect the committed changes.