In most cases the FriendDecl contains the declaration of the befriended
class as a child node, so it is discovered during the recursive
visitation. However, there are cases when the befriended class is not a
child, thus it must be fetched explicitly from the FriendDecl, and only
then can we add it to the lookup table.
(Note, this does affect only CTU and does not affect LLDB, because we
cannot and do not use the ASTImporterLookupTable in LLDB.)
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Hi Gabor,
This looks fine, but I have a question inline.
clang/unittests/AST/ASTImporterTest.cpp | ||
---|---|---|
4259 ↗ | (On Diff #200043) | Will getCanonicalType() do the job? |
clang/unittests/AST/ASTImporterTest.cpp | ||
---|---|---|
4259 ↗ | (On Diff #200043) | That's a good catch! Thank you for pointing out. |
clang/unittests/AST/ASTImporterTest.cpp | ||
---|---|---|
4259 ↗ | (On Diff #200043) | Thank you, this is indeed simpler, changed that. |