Page MenuHomePhabricator

[AArch64] only indicate CFI on Windows if we emitted CFI
ClosedPublic

Authored by froydnj on May 15 2019, 1:28 PM.

Details

Summary

Otherwise, we emit directives for CFI without any actual CFI opcodes to
go with them, which causes tools to malfunction. The technique is
similar to what the x86 backend already does.

Fixes https://bugs.llvm.org/show_bug.cgi?id=40876

Diff Detail

Repository
rL LLVM

Event Timeline

froydnj created this revision.May 15 2019, 1:28 PM
rnk accepted this revision.May 15 2019, 1:43 PM

lgtm

This revision is now accepted and ready to land.May 15 2019, 1:43 PM

Wow, thanks for the fast review! @rnk , could you please commit this for me? I do not have commit access. Thanks!

This revision was automatically updated to reflect the committed changes.
rnk added a comment.May 15 2019, 2:45 PM

Normally I would go ahead and land this, but I think I should let somebody who has more ownership over the ARM64 backend take a look first.

rnk added a comment.May 15 2019, 3:01 PM
In D61960#1503681, @rnk wrote:

Normally I would go ahead and land this, but I think I should let somebody who has more ownership over the ARM64 backend take a look first.

Nevermind, I see @mgrang landed it. Thanks!