User Details
- User Since
- Feb 6 2019, 11:04 AM (102 w, 3 d)
Sep 24 2020
Aug 28 2020
Throwing this back into the review queue.
Updated to use a struct instead of a union for the actual table in an effort to avoid UB.
Aug 12 2020
Ping for an opinion on the recent discussion of how to move forward with this patch.
Aug 3 2020
Ping for an opinion on the recent discussion of how to move forward with this patch.
Jul 28 2020
Jul 27 2020
Ping.
Jul 23 2020
Jul 1 2020
FWIW, an in-progress tree for the proposed move for all the architecture-specific builtins is:
Jun 30 2020
Cool, thank you! Could you also land this for me? I do not have commit privileges. Thanks!
Thanks for the pointer @craig.topper ! I've updated the patch to use LessRecordByID. I've also made some small changes to how the code selects the correct macro to output and done a better job converting the builtins by using an automated script, available at https://gist.github.com/froydnj/1192911af46661fb62e724957099d4e8 . I did have to touch up the comments a bit, but the more-automated conversion pointed out several errors that my attempt to use the preprocessor had run into.
Not sure who needs to review this; picking a familiar face. ;)
Jun 23 2020
Jun 15 2020
I'd like to apply the same sort of techniques to the builtin tables, which are enormous, but this is baby steps.
Dec 2 2019
Also, I am the farthest thing from the owner of this code (I don't even have commit access!), so I don't think I'm the right person to review this.
May 15 2019
Wow, thanks for the fast review! @rnk , could you please commit this for me? I do not have commit access. Thanks!
Feb 7 2019
Thanks for the review, @mstorsjo. Would you please land this for me? I don't have commit access.