Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

atrosinenko (Anatoly Trosinenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2020, 7:24 AM (183 w, 6 h)

Recent Activity

Oct 11 2023

atrosinenko committed rG1d2b558265bd: [AArch64][PAC] Check authenticated LR value during tail call (authored by atrosinenko).
[AArch64][PAC] Check authenticated LR value during tail call
Oct 11 2023, 7:39 AM · Restricted Project, Restricted Project
atrosinenko closed D156716: [AArch64][PAC] Check authenticated LR value during tail call.
Oct 11 2023, 7:39 AM · Restricted Project, Restricted Project
atrosinenko added a comment to D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Thank you for the review. I read through the comments - they are already addressed except maybe for a few FPAC-related notes, so I added a FIXME to checkAuthenticatedLR function and left a note in the discussion of D156784.

Oct 11 2023, 6:13 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Added FIXME mentioning FEAT_FPAC to AArch64PointerAuth::checkAuthenticatedLR.

Oct 11 2023, 6:09 AM · Restricted Project, Restricted Project
atrosinenko added a comment to D156784: [AArch64][PAC] Declare FPAC subtarget feature.

As discussed in D156716, it is not clear if I have to add FeatureFPAC to every relevant CPU. Maybe it is worth conservatively assuming that this feature should only be enabled manually by the user as a precaution against "I have CPU core X but it is not listed, so let's use cpu=Y because X supports all the instructions supported by Y (but not FEAT_FPAC)" - that would not cause any obvious run-time crashes under normal operation, but would make the code less secure.

Oct 11 2023, 5:39 AM · Restricted Project, Restricted Project, Restricted Project

Oct 9 2023

atrosinenko added inline comments to D156716: [AArch64][PAC] Check authenticated LR value during tail call.
Oct 9 2023, 9:36 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Moved AddressCheckPseudoSourceValue to AArch64SubtargetInfo.

Oct 9 2023, 9:13 AM · Restricted Project, Restricted Project

Oct 6 2023

atrosinenko added inline comments to D156716: [AArch64][PAC] Check authenticated LR value during tail call.
Oct 6 2023, 7:23 AM · Restricted Project, Restricted Project
atrosinenko added inline comments to D156716: [AArch64][PAC] Check authenticated LR value during tail call.
Oct 6 2023, 7:11 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Address the review comments.

Oct 6 2023, 6:47 AM · Restricted Project, Restricted Project

Oct 2 2023

atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Addressed the comments so far.

Oct 2 2023, 9:35 AM · Restricted Project, Restricted Project
atrosinenko added a comment to D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Updated the patch, thank you.

Oct 2 2023, 9:34 AM · Restricted Project, Restricted Project

Sep 29 2023

atrosinenko updated the diff for D156784: [AArch64][PAC] Declare FPAC subtarget feature.

Updated the patch:

Sep 29 2023, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
atrosinenko abandoned D152620: [IR] Define llvm.ptrauth wrapper globals.
Sep 29 2023, 2:37 AM · Restricted Project, Restricted Project

Sep 26 2023

atrosinenko added a comment to D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Here is a summary of the contents of this patch:

  • implemented a standalone llvm::AArch64PAuth::checkAuthenticatedRegister utility function to emit one of a number of checks in case a pointer is AUT'ed and not immediately used for memory access
    • placed this function into a sub-namespace instead of making it a static class member, so I don't have to put otherwise irrelevant AArch64PointerAuth class definition to header file
    • note that the checks that are inserted by checkAuthenticatedRegister function are not specific to tail calls (but some of the checks may have restrictions - such as requiring AuthenticatedReg == LR because XPACLRI is encoded as HINT while generic XPAC* instructions require FEAT_PAUTH)
  • hooked it to AArch64PointerAuth class via checkAuthenticatedLR method dedicated to hardening tail calls
  • in machine outliner, update the costs computed by AArch64InstrInfo::getOutliningCandidateInfo method on a best-effort basis:
    • in MachineOutlinerTailCall outlining mode, we need to insert checks in each caller of OUTLINED_FUNCTION
    • in MachineOutlinerThunk mode, at most a single extra check is inserted in OUTLINED_FUNCTION itself
    • other modes do not introduce new tail calls, so let's just try to account for the checks that would possibly be inserted later into the original candidates by the AArch64PointerAuth pass (including in the two aboves modes)
  • factored out isTailCallReturnInst and needsShadowCallStackPrologueEpilogue utility functions
Sep 26 2023, 5:40 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Rebased and updated the patch a bit more:

  • in getOutliningCandidateInfo, adjusted SequenceSize variable before its first use
  • updated code comments
  • skipped checking LR if Scadow Call Stack is enabled: the LR value just before TCRETURN* instruction is anyway not the one produced by AUT* (and we cannot check right after AUT* because we cannot be sure which register is usable as a temporary)
Sep 26 2023, 5:37 AM · Restricted Project, Restricted Project

Sep 22 2023

atrosinenko committed rGeb02ee44d325: [AArch64] Move PAuth codegen down the machine pipeline (authored by atrosinenko).
[AArch64] Move PAuth codegen down the machine pipeline
Sep 22 2023, 4:50 AM · Restricted Project, Restricted Project
atrosinenko closed D159357: [AArch64] Move PAuth codegen down the machine pipeline.
Sep 22 2023, 4:50 AM · Restricted Project, Restricted Project

Sep 19 2023

atrosinenko added inline comments to D159357: [AArch64] Move PAuth codegen down the machine pipeline.
Sep 19 2023, 8:45 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Updated after the D159357 was changed.

Sep 19 2023, 8:24 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D159357: [AArch64] Move PAuth codegen down the machine pipeline.

Addressed the review comments, rebased.

Sep 19 2023, 8:22 AM · Restricted Project, Restricted Project
atrosinenko updated the summary of D156716: [AArch64][PAC] Check authenticated LR value during tail call.
Sep 19 2023, 3:41 AM · Restricted Project, Restricted Project

Sep 18 2023

atrosinenko added a comment to D159357: [AArch64] Move PAuth codegen down the machine pipeline.

I don't understand the motivation here. This moves PAuth's instruction insertion later down the pipeline, but why? The handling in the machine outliner isn't made any simpler IMO.

Sep 18 2023, 8:06 AM · Restricted Project, Restricted Project
atrosinenko added inline comments to D159357: [AArch64] Move PAuth codegen down the machine pipeline.
Sep 18 2023, 7:51 AM · Restricted Project, Restricted Project

Sep 1 2023

atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.
  • Updated the patch based on the changes from D159357
  • Made the check opt-in for subtargets, "none" by default, with command line option to override
  • Fixed use after free in createCheckMemOperand function (the same way it is done in Hexagon)
Sep 1 2023, 12:43 PM · Restricted Project, Restricted Project
atrosinenko requested review of D159357: [AArch64] Move PAuth codegen down the machine pipeline.
Sep 1 2023, 6:50 AM · Restricted Project, Restricted Project

Aug 15 2023

atrosinenko added a comment to D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Reworked the patch

  • replaced "use a fast checker or not" boolean argument with multiple choices
  • created a separate source file and put checkAuthenticatedRegister() function there as it is likely to be later used by other parts of the codegen
  • exposed a tail-call-specific AArch64FrameLowering::checkAuthenticatedLR() similarly to signLR() and authenticateLR() so it can be used by outliner callbacks later
  • marked a dummy load instruction as volatile similar to Hexagon::PS_crash from HexagonInstrInfo.cpp
  • added the third implementation of authenticated address checker, similar to this code. Of course, more checkers can be implemented, but I think it would be better to leave this patch as a common implementation + a few "proofs of concept" and add more checkers via later patches, if needed.
Aug 15 2023, 8:51 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Refactoring.

Aug 15 2023, 8:13 AM · Restricted Project, Restricted Project

Aug 14 2023

atrosinenko planned changes to D156784: [AArch64][PAC] Declare FPAC subtarget feature.

Looks like adding FeatureFPAC may require changes in more places - need to investigate whether I have to add something like AEK_FPAC constant, etc.

Aug 14 2023, 9:50 AM · Restricted Project, Restricted Project, Restricted Project

Aug 11 2023

atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Rebased onto current main branch, will upload a few fixes shortly.

Aug 11 2023, 8:20 AM · Restricted Project, Restricted Project
atrosinenko committed rG81300f75f4da: [AArch64][PAC] Remove the duplication of LR sign/auth implementations (authored by atrosinenko).
[AArch64][PAC] Remove the duplication of LR sign/auth implementations
Aug 11 2023, 4:42 AM · Restricted Project, Restricted Project
atrosinenko closed D157320: [AArch64][PAC] Remove the duplication of LR sign/auth implementations.
Aug 11 2023, 4:42 AM · Restricted Project, Restricted Project
atrosinenko retitled D157320: [AArch64][PAC] Remove the duplication of LR sign/auth implementations from [AArch64][PAC] Remove duplication of LR sign/auth implementations to [AArch64][PAC] Remove the duplication of LR sign/auth implementations.
Aug 11 2023, 2:58 AM · Restricted Project, Restricted Project

Aug 10 2023

atrosinenko added inline comments to D156716: [AArch64][PAC] Check authenticated LR value during tail call.
Aug 10 2023, 7:12 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D157320: [AArch64][PAC] Remove the duplication of LR sign/auth implementations.

Rebased onto current main branch (after D156428). Further simplified the code by introducing the mergeOutliningCandidateAttributes() callback.

Aug 10 2023, 3:09 AM · Restricted Project, Restricted Project

Aug 8 2023

atrosinenko planned changes to D157320: [AArch64][PAC] Remove the duplication of LR sign/auth implementations.

Need to think a bit more if it is correct to just copy the PAuth-related function attributes in mergeOutliningCandidateAttributes - this would make it possible to pass less boolean arguments to signLR / authenticateLR.

Aug 8 2023, 11:33 AM · Restricted Project, Restricted Project

Aug 7 2023

atrosinenko requested review of D157320: [AArch64][PAC] Remove the duplication of LR sign/auth implementations.
Aug 7 2023, 12:27 PM · Restricted Project, Restricted Project

Aug 4 2023

atrosinenko updated subscribers of D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Updated the patch.

Aug 4 2023, 8:42 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D156716: [AArch64][PAC] Check authenticated LR value during tail call.

Address the review comments.

Aug 4 2023, 8:17 AM · Restricted Project, Restricted Project

Aug 1 2023

atrosinenko published D156785: [AArch64][PAC] Skip checking LR during tail call if FPAC is enabled for review.
Aug 1 2023, 4:02 AM · Restricted Project, Restricted Project
atrosinenko requested review of D156784: [AArch64][PAC] Declare FPAC subtarget feature.
Aug 1 2023, 3:30 AM · Restricted Project, Restricted Project, Restricted Project

Jul 31 2023

atrosinenko published D156716: [AArch64][PAC] Check authenticated LR value during tail call for review.

This patch is inspired by the commit https://github.com/ahmedbougacha/llvm-project/commit/58cf59b84ca4e7930a640480fd5ad1ea194864f5 (and uses the same immediate operand for BRK instruction) but adds the checks during epilogue insertion instead of asm printing.

Jul 31 2023, 9:54 AM · Restricted Project, Restricted Project
atrosinenko added a comment to D156358: [AArch64] Do not unnecessarily spill LR because of @llvm.returnaddress.

https://github.com/ahmedbougacha/llvm-project/commit/7924c7d75ae0015a9fd9786a580b10b2190bccc6

@atrosinenko do you want to try out that patch, see if it helps?

Jul 31 2023, 6:53 AM · Restricted Project, Restricted Project

Jul 29 2023

atrosinenko committed rG4210204f521b: [AArch64] Refactor checks in sign-return-address.ll test (authored by atrosinenko).
[AArch64] Refactor checks in sign-return-address.ll test
Jul 29 2023, 3:15 AM · Restricted Project, Restricted Project
atrosinenko closed D156327: [AArch64] Refactor checks in sign-return-address.ll test.
Jul 29 2023, 3:14 AM · Restricted Project, Restricted Project

Jul 28 2023

atrosinenko added a comment to D156358: [AArch64] Do not unnecessarily spill LR because of @llvm.returnaddress.

After debugging a bit more, I suspect that the actual reason for emitting XPACI LR is not the instruction selection phase but register allocation.

Jul 28 2023, 12:43 PM · Restricted Project, Restricted Project

Jul 27 2023

atrosinenko updated the diff for D156327: [AArch64] Refactor checks in sign-return-address.ll test.

Agree, updated the patch. Added comments in a few places where CHECK-NOT were more descriptive (spicifically, not emitting BTI before PACI(A|B)SP and not using RETAA with shadow call stack).

Jul 27 2023, 7:01 AM · Restricted Project, Restricted Project

Jul 26 2023

atrosinenko published D156358: [AArch64] Do not unnecessarily spill LR because of @llvm.returnaddress for review.

While most features of https://github.com/apple/llvm-project/commit/7924c7d75ae0015a9fd9786a580b10b2190bccc6 are already implemented in mainline, @llvm.returnaddress still tends to be lowered like

xpaci x30
mov dest, x30

instead of

mov dest, x30
xpaci dest

This patch forces the return address to be copied out of LR first, if FEAT_PAuth is avaialble (at the instruction selection phase).

Jul 26 2023, 12:26 PM · Restricted Project, Restricted Project
atrosinenko published D156327: [AArch64] Refactor checks in sign-return-address.ll test for review.
Jul 26 2023, 6:57 AM · Restricted Project, Restricted Project

Jul 25 2023

atrosinenko added a comment to D85917: [MSP430] Fix passing C structs and unions as function arguments.

Sorry for a hung patch. After getting the approval I had doubts that I interpret the corner cases of LLVM IR correctly. Thus, I postponed the patch these days to not subtly break the stable targets while fixing one issue on MSP430.

Jul 25 2023, 4:22 AM · Restricted Project, Restricted Project

Jun 15 2023

atrosinenko added a comment to D152620: [IR] Define llvm.ptrauth wrapper globals.

Here is the rebased branch: https://github.com/access-softek/llvm-project/tree/rebased-ptrauth. Some tests might fail as it is work-in-progress.

Jun 15 2023, 8:58 AM · Restricted Project, Restricted Project

Jun 10 2023

atrosinenko published D152620: [IR] Define llvm.ptrauth wrapper globals for review.
Jun 10 2023, 5:30 AM · Restricted Project, Restricted Project

Jun 8 2023

atrosinenko added a comment to D132384: [AArch64][PAC] Select MOVK for ptrauth.blend intrinsic..

I am planning to land this patch the next week, if there will be no objections.

Jun 8 2023, 5:22 AM · Restricted Project, Restricted Project

Jun 1 2023

atrosinenko added a comment to D132384: [AArch64][PAC] Select MOVK for ptrauth.blend intrinsic..

Could this patch be landed? (I can commit it on your behalf if appropriate)

Jun 1 2023, 10:33 AM · Restricted Project, Restricted Project

Jan 30 2022

atrosinenko committed rG4bcd2588a986: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z (authored by atrosinenko).
[compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z
Jan 30 2022, 12:07 PM
atrosinenko closed D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z.
Jan 30 2022, 12:06 PM · Restricted Project
atrosinenko committed rG9595f0051000: [compiler-rt][builtins] Use explicitly-sized integer types for LibCalls (authored by atrosinenko).
[compiler-rt][builtins] Use explicitly-sized integer types for LibCalls
Jan 30 2022, 10:15 AM
atrosinenko closed D86546: [compiler-rt][builtins] Use explicitly-sized integer types for LibCalls.
Jan 30 2022, 10:15 AM · Restricted Project

Apr 11 2021

atrosinenko updated subscribers of D99438: [SimplifyLibCalls] Take size of int into consideration when emitting ldexp/ldexpf.

The idea of introducing SizeOfInt to TargetLibraryInfo looks quite reasonable to me, although I am not too familiar with this part of target description.

Apr 11 2021, 9:52 AM · Restricted Project

Apr 9 2021

atrosinenko abandoned D85731: [NFC][builtins] Make softfloat-related errors less noisy.
Apr 9 2021, 7:20 AM · Restricted Project

Sep 22 2020

atrosinenko added a comment to D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z.

The (aWidth - 1) - clzsi(a) change is correct, but why is the ctz change?

Sep 22 2020, 3:22 AM · Restricted Project

Sep 11 2020

atrosinenko added a comment to D87520: [tests][compiler-rt] Implement generic_ldbl{80,128}_test targets.

See rG553833958fd as an example.

Sep 11 2020, 9:17 AM · Restricted Project
atrosinenko requested review of D87520: [tests][compiler-rt] Implement generic_ldbl{80,128}_test targets.
Sep 11 2020, 9:13 AM · Restricted Project

Sep 9 2020

atrosinenko added a comment to D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z.

Ping.

Sep 9 2020, 8:45 AM · Restricted Project
atrosinenko added a comment to D86546: [compiler-rt][builtins] Use explicitly-sized integer types for LibCalls.

Ping.

Sep 9 2020, 8:44 AM · Restricted Project

Sep 1 2020

atrosinenko committed rG553833958fde: [builtins] Fix divtf3_test.c (authored by atrosinenko).
[builtins] Fix divtf3_test.c
Sep 1 2020, 2:21 PM
atrosinenko committed rG93eed63d2f31: [builtins] Make __div[sdt]f3 handle denormal results (authored by atrosinenko).
[builtins] Make __div[sdt]f3 handle denormal results
Sep 1 2020, 11:55 AM
atrosinenko closed D85032: [builtins] Make divXf3 handle denormal results.
Sep 1 2020, 11:54 AM · Restricted Project
atrosinenko committed rG0e90d8d4fed8: [builtins] Unify the softfloat division implementation (authored by atrosinenko).
[builtins] Unify the softfloat division implementation
Sep 1 2020, 9:25 AM
atrosinenko closed D85031: [builtins] Unify the softfloat division implementation.
Sep 1 2020, 9:25 AM · Restricted Project

Aug 31 2020

atrosinenko added a comment to D85031: [builtins] Unify the softfloat division implementation.

Thank you very much for review!

Aug 31 2020, 2:00 PM · Restricted Project
atrosinenko updated the diff for D85031: [builtins] Unify the softfloat division implementation.

Update after the latest comments.

Aug 31 2020, 1:50 PM · Restricted Project
atrosinenko updated the diff for D85032: [builtins] Make divXf3 handle denormal results.

Re-upload after amending parent diff + add minor clarification.

Aug 31 2020, 6:26 AM · Restricted Project
atrosinenko updated the diff for D85031: [builtins] Unify the softfloat division implementation.

Clarify rounding-related part of function.

Aug 31 2020, 6:15 AM · Restricted Project
atrosinenko added a comment to D86453: [AArch64] Support conversion between fp16 and fp128.

Hi atrosinenko, do you think this patch need any more change on the testing side?
The fp_lib.h/int_lib.h change would most likely require in a more complex without
much gain in organization imho.

Aug 31 2020, 4:30 AM · Restricted Project, Restricted Project

Aug 30 2020

atrosinenko committed rG11cf6346fd49: [NFC][compiler-rt] Factor out __div[sdt]i3 and __mod[dt]i3 implementations (authored by atrosinenko).
[NFC][compiler-rt] Factor out __div[sdt]i3 and __mod[dt]i3 implementations
Aug 30 2020, 6:42 AM
atrosinenko closed D86400: [NFC][compiler-rt] Factor out __div[sdt]i3 and __mod[dt]i3 implementations.
Aug 30 2020, 6:42 AM · Restricted Project
atrosinenko updated the diff for D85032: [builtins] Make divXf3 handle denormal results.

Re-upload after amending parent diff.

Aug 30 2020, 6:03 AM · Restricted Project
atrosinenko updated the diff for D85031: [builtins] Unify the softfloat division implementation.

Add more clarifications, fix explanation for "why it is enough to adjust only once in case of overflow".

Aug 30 2020, 6:01 AM · Restricted Project

Aug 28 2020

atrosinenko updated the diff for D85032: [builtins] Make divXf3 handle denormal results.

Re-upload after changing parent diff.

Aug 28 2020, 8:57 AM · Restricted Project
atrosinenko updated the diff for D85031: [builtins] Unify the softfloat division implementation.

Add some other explanations.

Aug 28 2020, 8:57 AM · Restricted Project
atrosinenko updated the diff for D85031: [builtins] Unify the softfloat division implementation.

This update is expected to be completely NFC w.r.t. code behavior and significantly clarify the proof up to the end of half-width iterations.

Aug 28 2020, 7:01 AM · Restricted Project

Aug 27 2020

atrosinenko added inline comments to D85031: [builtins] Unify the softfloat division implementation.
Aug 27 2020, 9:14 AM · Restricted Project
atrosinenko updated the diff for D85032: [builtins] Make divXf3 handle denormal results.

No-change re-upload: rebase onto current master branch.

Aug 27 2020, 8:35 AM · Restricted Project
atrosinenko updated the diff for D85031: [builtins] Unify the softfloat division implementation.

No-change re-upload: rebase onto current master branch.

Aug 27 2020, 8:34 AM · Restricted Project
atrosinenko added a comment to D84602: [MSP430] Expose msp430_builtin calling convention to C code.

Pinging @echristo in case there is some trivial way to allocate a calling convention ID (but probably there is not, unless GCC allocated one already). As I understand, without this ID the debugger may show some misleading output for a limited number of LibCalls. On the other hand, it will not help either, unless the debugger knows this ID.

Aug 27 2020, 6:21 AM · Restricted Project, Restricted Project
atrosinenko updated the diff for D84602: [MSP430] Expose msp430_builtin calling convention to C code.
  • Rebase onto current master branch
  • Add a dummy switch case with FIXME, as suggested by @aaron.ballman
  • Applied a couple of style fixes proposed by linter
Aug 27 2020, 6:10 AM · Restricted Project, Restricted Project
atrosinenko added a comment to D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file.

Uploaded because it was already approved and no other review comments received since then. Anyway, please feel free to request followup changes if needed.

Aug 27 2020, 4:38 AM · Restricted Project
atrosinenko added a comment to D86289: [NFC][compiler-rt] Factor out __mulo[sdt]i3 implementations to .inc file.

Uploaded because it was already approved and no other review comments received since then. Anyway, please feel free to request followup changes if needed.

Aug 27 2020, 4:37 AM · Restricted Project
atrosinenko committed rGfce035eae980: [NFC][compiler-rt] Factor out __mulo[sdt]i4 implementations to .inc file (authored by atrosinenko).
[NFC][compiler-rt] Factor out __mulo[sdt]i4 implementations to .inc file
Aug 27 2020, 4:37 AM
atrosinenko committed rG182d14db07f1: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file (authored by atrosinenko).
[NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file
Aug 27 2020, 4:37 AM
atrosinenko closed D86289: [NFC][compiler-rt] Factor out __mulo[sdt]i3 implementations to .inc file.
Aug 27 2020, 4:37 AM · Restricted Project
atrosinenko closed D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file.
Aug 27 2020, 4:36 AM · Restricted Project

Aug 25 2020

atrosinenko abandoned D86221: [compiler-rt][builtins] Do not assume int to be at least 32 bit wide.

Replaced this by D86546: [compiler-rt][builtins] Use explicitly-sized integer types for LibCalls and D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z. These two patches include everything except for factoring out src_rep_t_clz() and rep_clz() to clzdi() for now.

Aug 25 2020, 9:16 AM · Restricted Project
atrosinenko requested review of D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z.
Aug 25 2020, 9:10 AM · Restricted Project
atrosinenko requested review of D86546: [compiler-rt][builtins] Use explicitly-sized integer types for LibCalls.
Aug 25 2020, 9:09 AM · Restricted Project
atrosinenko added a comment to D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls.

Uploaded, thank you!

Aug 25 2020, 6:24 AM · Restricted Project
atrosinenko committed rGe1edc1c76dc1: [Utils] Add highlighting definition for byref IR attribute (authored by atrosinenko).
[Utils] Add highlighting definition for byref IR attribute
Aug 25 2020, 6:23 AM
atrosinenko committed rGb9f49d13fd44: [compiler-rt][builtins] Add more test cases for __div[sdt]f3 LibCalls (authored by atrosinenko).
[compiler-rt][builtins] Add more test cases for __div[sdt]f3 LibCalls
Aug 25 2020, 6:23 AM
atrosinenko closed D85768: [Utils] Add highlighting definition for byref IR attribute.
Aug 25 2020, 6:23 AM · Restricted Project