Page MenuHomePhabricator

[AMDGPU][MC][GFX8][GFX9] Corrected predicate of v_*_co_u32 aliases
ClosedPublic

Authored by dp on May 14 2019, 8:38 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

dp created this revision.May 14 2019, 8:38 AM
rampitec requested changes to this revision.May 14 2019, 8:44 AM

GFX10 changes are not yet complete.

This revision now requires changes to proceed.May 14 2019, 8:44 AM
dp added a comment.May 14 2019, 8:50 AM

SWDEV-188513 is P2. Could you correct the offending predicate by your next commit?
Or I can remove all changes except the predicate correction - that will not affect GFX10.

In D61905#1501536, @dp wrote:

SWDEV-188513 is P2. Could you correct the offending predicate by your next commit?
Or I can remove all changes except the predicate correction - that will not affect GFX10.

Please strip it to predicate and test only.

dp updated this revision to Diff 199473.May 14 2019, 9:30 AM
dp retitled this revision from [AMDGPU][MC][GFX8][GFX9][GFX10] Corrected v_*_co_u32 and v_*_co_ci_u32 aliases to [AMDGPU][MC][GFX8][GFX9] Corrected v_*_co_u32 aliases.
dp edited the summary of this revision. (Show Details)

Removed GFX10-relevant changes

The comment does not belong here. Also please retitle.

lib/Target/AMDGPU/VOP2Instructions.td
1347 ↗(On Diff #199473)

Remove this line please.

dp updated this revision to Diff 199478.May 14 2019, 10:40 AM
dp retitled this revision from [AMDGPU][MC][GFX8][GFX9] Corrected v_*_co_u32 aliases to [AMDGPU][MC][GFX8][GFX9] Corrected predicate of v_*_co_u32 aliases.
dp edited the summary of this revision. (Show Details)

Retitled and removed a comment

This revision is now accepted and ready to land.May 14 2019, 10:43 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2019, 12:13 PM