Move generic redecl chain tests and visibility tests into their own
separate test files.
Details
Details
- Reviewers
a_sidorin a.sidorin shafik - Commits
- rZORGb575ca47386f: [ASTImporter] Separate unittest files
rZORG69ea8da65801: [ASTImporter] Separate unittest files
rGb575ca47386f: [ASTImporter] Separate unittest files
rG69ea8da65801: [ASTImporter] Separate unittest files
rG3c72fe1bad4a: [ASTImporter] Separate unittest files
rL360572: [ASTImporter] Separate unittest files
rC360572: [ASTImporter] Separate unittest files
Diff Detail
Diff Detail
- Repository
- rC Clang
Event Timeline
Comment Actions
Hi Gabor,
I like this change! LGTM, just a few nits.
clang/unittests/AST/ASTImporterGenericRedeclTest.cpp | ||
---|---|---|
20 ↗ | (On Diff #199020) | Is this FIXME obsolete now? |
clang/unittests/AST/ASTImporterVisibilityTest.cpp | ||
37 ↗ | (On Diff #199020) | Can we use StringRef (or, at least const auto *)? |
49 ↗ | (On Diff #199020) | Double spaces in the end of sentences look a bit strange. |
139 ↗ | (On Diff #199020) | |
157 ↗ | (On Diff #199020) | This should fit a single line. |
190 ↗ | (On Diff #199020) | const? |
Comment Actions
Thanks for the review Alexei!
clang/unittests/AST/ASTImporterGenericRedeclTest.cpp | ||
---|---|---|
20 ↗ | (On Diff #199020) | Yes, that's correct, thank you for finding it! |
clang/unittests/AST/ASTImporterVisibilityTest.cpp | ||
49 ↗ | (On Diff #199020) | Ok I removed them. (Note, this is the result of some autoformatting option in vim, could not discover which specific setting causes the insertion of double spaces.) |