To unify the way we create threads in clangd.
This should simplify landing D50993.
Details
Details
- Reviewers
kadircet - Commits
- rZORGeea5465de208: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread
rZORG2614d51f7880: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread
rGeea5465de208: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread
rG2614d51f7880: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread
rCTE360332: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread
rGdb68b104d8d4: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread
rL360332: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 31665 Build 31664: arc lint + arc unit
Event Timeline
Comment Actions
- Count from 0.
clang-tools-extra/clangd/index/Background.cpp | ||
---|---|---|
152 | Done. The worker numbers still start with 1, sorry about that :-) | |
164 | Yeah, but then we'll have to ensure the AsyncTaskRunner is the last member (I've been bitten by this before). |
clang-tools-extra/trunk/clangd/index/Background.cpp | ||
---|---|---|
164 ↗ | (On Diff #198795) | This is already called in ~AsyncTaskRunner. |
NIT: why not count from zero :P