This is an archive of the discontinued LLVM Phabricator instance.

Add ".dword" directive
ClosedPublic

Authored by void on May 8 2019, 11:33 PM.

Diff Detail

Event Timeline

void created this revision.May 8 2019, 11:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2019, 11:33 PM
void added a comment.May 8 2019, 11:34 PM

This is the doc saying dword == xword:

http://www.rowleydownload.co.uk/arm/documentation/gnu/as/AArch64-Directives.html

Could you add a test?

nickdesaulniers added inline comments.May 9 2019, 9:38 AM
lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
244

Maybe add a . before the [dx]?

void updated this revision to Diff 198900.May 9 2019, 1:55 PM

Add testcase.

void edited the summary of this revision. (Show Details)May 9 2019, 1:56 PM
void marked an inline comment as done.

Could you add a test?

Done.

nickdesaulniers added inline comments.May 9 2019, 2:07 PM
test/MC/AArch64/size-directive.s
25 ↗(On Diff #198900)

preceding space?

void updated this revision to Diff 198909.May 9 2019, 2:28 PM

Remove errant space.

void marked an inline comment as done.May 9 2019, 2:29 PM
nickdesaulniers accepted this revision.May 9 2019, 2:47 PM
This revision is now accepted and ready to land.May 9 2019, 2:47 PM
This revision was automatically updated to reflect the committed changes.