This is an archive of the discontinued LLVM Phabricator instance.

Add .dword direcrive support for aarch64 mc
ClosedPublic

Authored by raj.khem on Jan 31 2019, 11:05 AM.

Details

Reviewers
rengolin
Summary

.dword is used in many packages in linux world. The last I run into is klibc.

Diff Detail

Repository
rL LLVM

Event Timeline

raj.khem created this revision.Jan 31 2019, 11:05 AM
rengolin accepted this revision.Jan 31 2019, 11:35 AM

dword is indeed widely used. I'm surprised we didn't support that yet. Apparently, neither does Arm, only X86, Mips and RiscV.

This revision is now accepted and ready to land.Jan 31 2019, 11:35 AM

@rengolin who can help committing this patch ?

Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2019, 3:01 PM

A patch adding the same functionality was added back in May: D61719, rL360381.

Reviewers tend to assume that patch authors have commit access, if you don't then just say so when the patch is accepted and the reviewer will commit it for you.

A patch adding the same functionality was added back in May: D61719, rL360381.

Reviewers tend to assume that patch authors have commit access, if you don't then just say so when the patch is accepted and the reviewer will commit it for you.

thanks, as long as the issues are fixed this is fine.

raj.khem closed this revision.Nov 23 2019, 7:25 PM