Page MenuHomePhabricator

[ARM] Fix the extensions implied by a cpu name
ClosedPublic

Authored by dnsampaio on May 8 2019, 2:26 AM.

Details

Summary

When using clang -mcpu=CPUNAME+FEATURELIST,
the implied features defined by CPUNAME are
not obtained, as the entire string is passed.
This fixes that by spiting the cpuname
string in the first +, if any.

For example, when using

clang -### --target=arm-arm-none-eabi -march=armv7-a -mcpu=cortex-a8+nocrc

the intrinsic

"target-feature" "+dsp"

implied by cortex-a8 is missing.

Diff Detail

Repository
rL LLVM

Event Timeline

dnsampaio created this revision.May 8 2019, 2:26 AM

LGTM but the use of "intrinsic" in the commit message is confusing. Do you mean feature/implied feature, as in "the implied features defined by"?

dnsampaio edited the summary of this revision. (Show Details)May 8 2019, 2:56 AM
DavidSpickett accepted this revision.May 9 2019, 2:13 AM
This revision is now accepted and ready to land.May 9 2019, 2:13 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2019, 3:22 AM