User Details
- User Since
- Jan 5 2018, 8:33 AM (100 w, 6 d)
Fri, Nov 29
Reverted.
Tue, Nov 26
Hi @efriedma, thanks your comments. You're right, that was hasty of me. Apologies for that, it won't happen again.
Fri, Nov 15
I think there's been plenty of time for comments here. LGTM.
Oct 30 2019
Just want to double check with @efriedma, before we except this. I believe this patch now catches all the points you made on https://reviews.llvm.org/D56005. Anything we've missed?
Oct 17 2019
Oct 15 2019
Oct 14 2019
IMHO, since reserved registes are per-function, this strongly suggests implementation as function attribute(s), rather than subtarget features (also for the pre-existing r9).
Oct 11 2019
Superseded by https://reviews.llvm.org/D68862.
Superseded by https://reviews.llvm.org/D68862.
Sep 6 2019
Aug 1 2019
NFC test commit. LGTM.
Jul 25 2019
Mar 22 2019
Mar 15 2019
Done. I've added an extra parameter over what you might expect as classifyArgumentTypes doesn't seem to consider AAPCS16, whereas classifyReturnTypes does.
I've also renamed the variable to make the distinction between it and the function clearer.
Mar 14 2019
I got bit a confused earlier. That does actually seem like correct behaviour (once we're no longer able to treat the struct as a homogeneous aggregate).
I've tightened up the conditional a bit as it wouldn't have previously accounted for the case where you had mfloat-abi=hard with an AAPCS (non VFP) attribute. Although in this instance, the backend does seem to be correcting/ignoring that, it's still best we don't blindly rely on such behaviour.
Mar 8 2019
Mar 7 2019
Feb 21 2019
Not at all, thank you your comments.
Feb 15 2019
Hi @eli.friedman, are you still happy to review this?
Feb 5 2019
Removed the complicated frame pointer/ffixed combination errors in favour of an always on warning (in a new group, so it can be silenced).
Fixed an oversight where R6 could be used as the base pointer, even with ffixed-r6 specified.
Jan 24 2019
Thanks for the changes! LGTM. Approved.
Jan 23 2019
Added more test coverage, notably that to catch issues with using reserved registers for alignment and making up Thumb reg deficit.
More tests, and better handling of argument combination errors.
Thanks for posting this! Always good to doc updates.
Bit of _very_ opinionated bit of bike-shedding. Content otherwise LGTM!
Jan 18 2019
Hi, we're currently working on similar functionality for the ARM backend, so I got pointed to take a look at this patch.
Looks good to me, I quite like the tablegen improvements, but agree with trong's comments.
Jan 15 2019
Added cfe-commits.
Added llvm-commits.
Jan 14 2019
Added some regression tests for invalid -ffixed-reg combinations and the declaration of (un)supported variables.
Jan 11 2019
- Re-implementation using subtarget features over metadata.
- Reduction of register range to R5-R11.
- Additional checks to fix issues with spilling registers for stack alignment.
- Re-implementation using subtarget features over metadata.
- Reduction of register range to R5-R11.
- Additional checks to fix issues with spilling registers for stack alignment.
- Added clang errors for conflicting options with reserved registers.
Dec 21 2018
Dec 17 2018
Dec 12 2018
Reworded -fstack-protector-all to bring it in line with the changes to the other two options.
Dec 11 2018
Make thopre's suggested changes.
Dec 7 2018
Edited Options.td directly, rather than the generated docs file.
Jan 22 2018
Missing colon
Jan 19 2018
Jan 16 2018
Improved code formatting based on review