Page MenuHomePhabricator

keith.walker.arm (Keith Walker)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2013, 6:23 AM (315 w, 3 d)

Recent Activity

Sep 24 2019

keith.walker.arm added a comment to D67216: [cfi] Add flag to always generate .debug_frame.

I feel that using a -g option make more sense.

Sep 24 2019, 8:43 AM · Restricted Project, Restricted Project

Jul 23 2018

keith.walker.arm added a comment to D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR.

This change fixed a failing build here, so it looks correct to me.

Jul 23 2018, 7:29 AM

May 17 2018

keith.walker.arm added inline comments to D46970: [WebAssembly] MC: Ensure that FUNCTION_OFFSET relocations are always against function symbols..
May 17 2018, 12:55 AM

Feb 12 2018

keith.walker.arm added a comment to D42569: [ARM] disable FPU features when using soft floating point..

review request ping.

Feb 12 2018, 1:32 AM

Jan 26 2018

keith.walker.arm created D42569: [ARM] disable FPU features when using soft floating point..
Jan 26 2018, 2:11 AM

Nov 28 2017

keith.walker.arm updated the diff for D40256: [ARM] disable FPU features when using soft floating point..

What are these disabled "R-UN" lines?

Nov 28 2017, 8:19 AM

Nov 22 2017

keith.walker.arm updated the diff for D40256: [ARM] disable FPU features when using soft floating point..

I have updated the patch with the suggested change to use a list of features to disable.

Nov 22 2017, 6:59 AM

Nov 21 2017

keith.walker.arm added inline comments to D40256: [ARM] disable FPU features when using soft floating point..
Nov 21 2017, 3:25 AM

Nov 20 2017

keith.walker.arm added a reviewer for D40256: [ARM] disable FPU features when using soft floating point.: compnerd.
Nov 20 2017, 9:07 AM
keith.walker.arm created D40256: [ARM] disable FPU features when using soft floating point..
Nov 20 2017, 8:55 AM

Mar 7 2017

keith.walker.arm added a comment to D30681: Let arm_section_length store the number of bytes..

This change looks OK to me.

Mar 7 2017, 7:11 AM

Feb 20 2017

keith.walker.arm added a comment to D29578: Propagate debug info for Phi node in SSAUpdater.

I currently don't know of any other optimisation phases where the debug information for the results of a phi node is incorrect; but I would not be surprised to find that once the loop rotate issue is fixed and the information is able to correctly propagate in this phase that other optimisation phases which copy phi nodes are also found to have a problem.

Feb 20 2017, 5:42 AM

Feb 8 2017

keith.walker.arm added a comment to D29578: Propagate debug info for Phi node in SSAUpdater.

This change looks good to me, but I think it would be good if someone more experienced than me in the usage of debug metadata could give the final OK to this change.

Feb 8 2017, 1:09 AM

Oct 5 2016

keith.walker.arm added a comment to D24998: Add a new optimization option -Og .

Looking into what optimisations would be relevant to -Og (or rather what optimisation should be omitted because they are too disruptive to the debug experience) is something that I have on my road-map as something to look into and gather feedback on.

Oct 5 2016, 2:19 AM

Sep 28 2016

keith.walker.arm added a comment to D24994: PR26055: Teach LiveDebugValues about lexical scopes..

Looks good to me .... but I'll let Daniel give the final OK.

Sep 28 2016, 1:22 AM

Sep 27 2016

keith.walker.arm updated the diff for D24927: Propagate DBG_VALUE entries when there are unvisited predecessors .

Correct spelling mistakes in comments.
Converted the test to a MIR testcase

Sep 27 2016, 7:27 AM

Sep 26 2016

keith.walker.arm retitled D24927: Propagate DBG_VALUE entries when there are unvisited predecessors from to Propagate DBG_VALUE entries when there are unvisited predecessors .
Sep 26 2016, 10:00 AM

Sep 21 2016

keith.walker.arm added a comment to D24797: Only insert debug nodes after a phi if there is a valid insertion point .

I believe this change is good as a general back-stop check.

Sep 21 2016, 9:26 AM
keith.walker.arm retitled D24797: Only insert debug nodes after a phi if there is a valid insertion point from to Only insert debug nodes after a phi if there is a valid insertion point .
Sep 21 2016, 7:04 AM

Sep 16 2016

keith.walker.arm updated the diff for D23715: Add @llvm.dbg.value entries for the phi node created by -mem2reg.

Updated PhiHasDebugValue() to avoid scanning the whole instructions stream by using a new function llvm::FindAllocaDbgValues(). This new function is similar to the exiting function llvm::FindAllocaDbgDeclare() but has the additional complication that the result of the find can find multiple entries when applied to a phi node.

Sep 16 2016, 8:19 AM

Aug 23 2016

keith.walker.arm added inline comments to D23715: Add @llvm.dbg.value entries for the phi node created by -mem2reg.
Aug 23 2016, 9:37 AM

Aug 21 2016

keith.walker.arm updated the diff for D23715: Add @llvm.dbg.value entries for the phi node created by -mem2reg.
  • Moved the changes for ensuring the lowered load instruction in placed before the DEBUG_VALUE entry into a separate change: https://reviews.llvm.org/D23760
  • Updated PhiHasDebugValue() to use llvm::any_of
Aug 21 2016, 7:45 AM
keith.walker.arm retitled D23760: Place the lowered phi instruction(s) before the DEBUG_VALUE entry from to Place the lowered phi instruction(s) before the DEBUG_VALUE entry.
Aug 21 2016, 7:42 AM

Aug 19 2016

keith.walker.arm added a comment to D23715: Add @llvm.dbg.value entries for the phi node created by -mem2reg.

Thanks for the review, I will update the patch taking into account of your comments.

Aug 19 2016, 9:43 AM
keith.walker.arm retitled D23715: Add @llvm.dbg.value entries for the phi node created by -mem2reg from to Add @llvm.dbg.value entries for the phi node created by -mem2reg.
Aug 19 2016, 8:28 AM

Jan 18 2016

keith.walker.arm added a comment to D16064: Write AArch64 big endian data fixup entries as BE..

This fixes PR23020?

Jan 18 2016, 3:07 AM

Jan 11 2016

keith.walker.arm updated the diff for D16064: Write AArch64 big endian data fixup entries as BE..

Fixed line length issue.
Renamed getFixupKindContainereSizeBytes() to getFixupKindContainereSizeInBytes()

Jan 11 2016, 8:24 AM
keith.walker.arm retitled D16064: Write AArch64 big endian data fixup entries as BE. from to Write AArch64 big endian data fixup entries as BE..
Jan 11 2016, 7:15 AM

Aug 21 2015

keith.walker.arm retitled D12240: [AArch64] Define the macro __ARM_FP16_ARGS from to [AArch64] Define the macro __ARM_FP16_ARGS.
Aug 21 2015, 8:59 AM

May 12 2015

keith.walker.arm accepted D9558: [DWARF] Add CIE header fields address_size and segment_size when generating dwarf-4 .
May 12 2015, 7:40 AM
keith.walker.arm abandoned D2584: Print operands of DWARF stack frame operations..

This very old change never got committed (apologies to the reviewers) and the functionality has since been implement by friss in commit r230551

May 12 2015, 7:34 AM
keith.walker.arm updated the diff for D9558: [DWARF] Add CIE header fields address_size and segment_size when generating dwarf-4 .

Changed SegmentSize to SegmentDescriptorSize.
Added comment to CIE test to explain that the DW_CFA_nop instructions are padding.

May 12 2015, 5:30 AM
keith.walker.arm added a comment to D9558: [DWARF] Add CIE header fields address_size and segment_size when generating dwarf-4 .

Thanks for review my patch. I agree that segment_descriptor-size does appear to be a more appropriate name.

May 12 2015, 3:10 AM

May 11 2015

keith.walker.arm added reviewers for D9558: [DWARF] Add CIE header fields address_size and segment_size when generating dwarf-4 : dblaikie, echristo.
May 11 2015, 3:40 AM

May 7 2015

keith.walker.arm added a comment to D9558: [DWARF] Add CIE header fields address_size and segment_size when generating dwarf-4 .

Forgot to subscribe llvm-commits to the phabricator subscriber field, so repeating the initial summary as a comment in the hope this will make it to the mailing list.

May 7 2015, 7:19 AM
keith.walker.arm updated subscribers of D9558: [DWARF] Add CIE header fields address_size and segment_size when generating dwarf-4 .
May 7 2015, 6:47 AM
keith.walker.arm retitled D9558: [DWARF] Add CIE header fields address_size and segment_size when generating dwarf-4 from to [DWARF] Add CIE header fields address_size and segment_size when generating dwarf-4 .
May 7 2015, 6:38 AM