- User Since
- Oct 25 2013, 6:23 AM (335 w, 2 d)
Thu, Mar 26
Jan 22 2020
LGTM. Good to add missing tests for features that have been committed.
Sep 24 2019
I feel that using a -g option make more sense.
Jul 23 2018
This change fixed a failing build here, so it looks correct to me.
May 17 2018
Feb 12 2018
review request ping.
Jan 26 2018
Nov 28 2017
What are these disabled "R-UN" lines?
Nov 22 2017
I have updated the patch with the suggested change to use a list of features to disable.
Nov 21 2017
Nov 20 2017
Mar 7 2017
This change looks OK to me.
Feb 20 2017
I currently don't know of any other optimisation phases where the debug information for the results of a phi node is incorrect; but I would not be surprised to find that once the loop rotate issue is fixed and the information is able to correctly propagate in this phase that other optimisation phases which copy phi nodes are also found to have a problem.
Feb 8 2017
This change looks good to me, but I think it would be good if someone more experienced than me in the usage of debug metadata could give the final OK to this change.
Oct 5 2016
Looking into what optimisations would be relevant to -Og (or rather what optimisation should be omitted because they are too disruptive to the debug experience) is something that I have on my road-map as something to look into and gather feedback on.
Sep 28 2016
Looks good to me .... but I'll let Daniel give the final OK.
Sep 27 2016
Correct spelling mistakes in comments.
Converted the test to a MIR testcase
Sep 26 2016
Sep 21 2016
I believe this change is good as a general back-stop check.
Sep 16 2016
Updated PhiHasDebugValue() to avoid scanning the whole instructions stream by using a new function llvm::FindAllocaDbgValues(). This new function is similar to the exiting function llvm::FindAllocaDbgDeclare() but has the additional complication that the result of the find can find multiple entries when applied to a phi node.
Aug 23 2016
Aug 21 2016
- Moved the changes for ensuring the lowered load instruction in placed before the DEBUG_VALUE entry into a separate change: https://reviews.llvm.org/D23760
- Updated PhiHasDebugValue() to use llvm::any_of
Aug 19 2016
Thanks for the review, I will update the patch taking into account of your comments.
Jan 18 2016
Jan 11 2016
Fixed line length issue.
Renamed getFixupKindContainereSizeBytes() to getFixupKindContainereSizeInBytes()
Aug 21 2015
May 12 2015
This very old change never got committed (apologies to the reviewers) and the functionality has since been implement by friss in commit r230551
Changed SegmentSize to SegmentDescriptorSize.
Added comment to CIE test to explain that the DW_CFA_nop instructions are padding.
Thanks for review my patch. I agree that segment_descriptor-size does appear to be a more appropriate name.
May 11 2015
May 7 2015
Forgot to subscribe llvm-commits to the phabricator subscriber field, so repeating the initial summary as a comment in the hope this will make it to the mailing list.