Page MenuHomePhabricator
Differential D61492

AMDGPU: Prepare for explicit absolute relocations in code generation
ClosedPublic
Actions

Authored by nhaehnle on May 3 2019, 5:02 AM.

Details

Reviewers
arsenm
rampitec
kzhuravl
Commits
rG41abf2766e26: AMDGPU: Prepare for explicit absolute relocations in code generation
rL363517: AMDGPU: Prepare for explicit absolute relocations in code generation
Summary

We will use absolute relocations for LDS symbols.

Change-Id: I9a32795ed0ea835e433a787129cfe3c57ee9a325

Diff Detail

Repository
rL LLVM

Event Timeline

nhaehnle created this revision.May 3 2019, 5:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2019, 5:02 AM
Herald added subscribers: t-tye, tpr, dstuttard and 4 others. · View Herald Transcript
Harbormaster completed remote builds in B31350: Diff 197960.May 3 2019, 5:02 AM
nhaehnle added a child revision: D61493: AMDGPU/MC: Add .amdgpu_lds directive.May 3 2019, 5:04 AM
nhaehnle added a parent revision: D61491: AMDGPU: Be explicit about whether the high-word in SI_PC_ADD_REL_OFFSET is 0.
arsenm added inline comments.May 3 2019, 5:53 AM
lib/Target/AMDGPU/SIInstrInfo.cpp
5536–5538 ↗(On Diff #197960)

Should add tests in test/CodeGen/MIR/AMDGPU

nhaehnle added a reviewer: kzhuravl.May 6 2019, 9:17 AM
nhaehnle updated this revision to Diff 198438.May 7 2019, 4:48 AM
nhaehnle marked an inline comment as done.

Add a test/CodeGen/MIR/AMDGPU test.

Harbormaster completed remote builds in B31521: Diff 198438.May 7 2019, 4:48 AM
nhaehnle added a comment.May 15 2019, 10:33 AM

ping?

arsenm accepted this revision.May 19 2019, 8:58 AM

LGTM with nit

lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp
405–408 ↗(On Diff #198438)

return Kind != lo && Kind != Hi

This revision is now accepted and ready to land.May 19 2019, 8:58 AM
nhaehnle marked 2 inline comments as done.Jun 16 2019, 10:40 AM
nhaehnle added inline comments.
lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp
405–408 ↗(On Diff #198438)

Yeah, that makes sense. Thanks!

Closed by commit rL363517: AMDGPU: Prepare for explicit absolute relocations in code generation (authored by nha). · Explain WhyJun 16 2019, 10:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
include/
llvm/
MC/
2 lines
lib/
MC/
4 lines
Target/
AMDGPU/
13 lines
MCTargetDesc/
8 lines
7 lines
4 lines
test/
CodeGen/
MIR/
AMDGPU/
4 lines

Diff 204961

View Options

llvm/trunk/include/llvm/MC/MCExpr.h

Loading...
View Options

llvm/trunk/lib/MC/MCExpr.cpp

Loading...
View Options

llvm/trunk/lib/Target/AMDGPU/AMDGPUMCInstLower.cpp

Loading...
View Options

llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp

Loading...
View Options

llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.h

Loading...
View Options

llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cpp

Loading...
View Options

llvm/trunk/test/CodeGen/MIR/AMDGPU/target-flags.mir

Loading...