AMDGPU: Prepare for explicit absolute relocations in code generation
ClosedPublic
Actions

Authored by nhaehnle on May 3 2019, 5:02 AM.

Details

Reviewers

Commits

Summary

We will use absolute relocations for LDS symbols.

Change-Id: I9a32795ed0ea835e433a787129cfe3c57ee9a325

lib/Target/AMDGPU/SIInstrInfo.cpp
5536–5538 ↗	(On Diff #197960)	Should add tests in test/CodeGen/MIR/AMDGPU

Add a test/CodeGen/MIR/AMDGPU test.

ping?

LGTM with nit

lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp
405–408 ↗	(On Diff #198438)	return Kind != lo && Kind != Hi

This revision is now accepted and ready to land.May 19 2019, 8:58 AM

nhaehnle marked 2 inline comments as done.Jun 16 2019, 10:40 AM

nhaehnle added inline comments.

lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp
405–408 ↗	(On Diff #198438)	Yeah, that makes sense. Thanks!

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			llvm/trunk/include/llvm/MC/MCExpr.h (2 lines)
M			llvm/trunk/lib/MC/MCExpr.cpp (4 lines)
M			llvm/trunk/lib/Target/AMDGPU/AMDGPUMCInstLower.cpp (13 lines)
M			llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp (8 lines)
M			llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.h (7 lines)
M			llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cpp (4 lines)
M			llvm/trunk/test/CodeGen/MIR/AMDGPU/target-flags.mir (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	197960	359533		May 3 2019, 5:02 AM	★	★
Diff 2	198438	360123	Add a test/CodeGen/MIR/AMDGPU test.	May 7 2019, 4:48 AM	★	★
Diff 3	204961	363516	rL363517	Jun 16 2019, 10:43 AM	★	★

Status	Author	Revision
Closed	nhaehnle	D61494 AMDGPU: Write LDS objects out as global symbols in code generation
Closed	nhaehnle	D61493 AMDGPU/MC: Add .amdgpu_lds directive
Closed	nhaehnle	D61492 AMDGPU: Prepare for explicit absolute relocations in code generation
Closed	nhaehnle	D61491 AMDGPU: Be explicit about whether the high-word in SI_PC_ADD_REL_OFFSET is 0
Closed	nhaehnle	D61651 [MachineOperand] Add a ChangeToGA method
Closed	nhaehnle	D61650 [AsmPrinter] Make EmitLinkage and EmitVisibility public
Closed	nhaehnle	D63392 AMDGPU: Explicitly define a triple for some tests