Add additional information to help beginners submit reviews.
I'm don't know what you mean by 'appropriate repo field'. I've emphasied there must be one or more Reviewers.
Or do you mean something else?
Ok, so instead of:
"It requires one or more Reviewers and allows zero or more Subscribers, finding-reviewer-names_."
"arc requires one or more Reviewers (finding-reviewer-names_) and Subscribers should be llvm-commits plus the appropriate -dev list(s) from listinfo."
I'll update llvm/docs/Phabricator-commit-message.png when I get it right :)
Not sure I understand your question -- don't use gui's, but figure they can't be that different.
In any case, after you create a new patch in phab, you can update it by simply typeing arc diff. If you want to do it from somewhere other than where you originally ran the initial arc diff, you need to use the --update option, e.g., arc diff --update D61267.
You don't need to do anything else. For example, look at the first few lines of history at the top of this page. You'll see that Herald add the llvm project, and subscribed llvm-commits. It's a one-time thing you don't need to worry about.
As for @lebedev.ri comment about it not always working, personally, I'd consider that a bug and raise it on the list. I think @benhamilton fixed a few of those for me a couple of years ago. However, it doesn't hurt to mention it in the docs. hth... don
It seems adding "xxx-commit" doesn't hurt and its nice Hearld will do the right thing. I went ahead and updated the text and Phabricator-commit-message.png image.
If you guys would like something different, let me know.
(I think there are scenarios where someone can run arc diff from a different directory or upload a diff directly to Phabricator which can bypass its detection of the repository, which could explain @lebedev.ri 's issues. Regardless, directly reporting problems can help.)
I've added a few reviewers more familiar with this documentation.
My main concern is the addition of images. None of the other documentation has any, and I'm not sure about the policy, so I'll leave that question to others.
However, I have made a couple comments below.
I think it would be helpful to include the subscribers info @benhamilton provided.
You could also mention arc cover here.
I'd add one more sentence here, to tell people that in the case that they are doing the currently-recommend thing, they do _NOT_ need to worry about this. Something like: